Skip to content

Update python-for-android prerequisites (Dockerfile, prerequisites.py, docs) #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 20, 2023
Merged

Update python-for-android prerequisites (Dockerfile, prerequisites.py, docs) #2923

merged 5 commits into from
Nov 20, 2023

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Nov 18, 2023 •
edited
Loading

  • Updates Dockerfile (clean up of old requirements and change of base image)
  • Set JDK version 17 as a prerequisite, newer JDK versions such as 21 are incompatible with our version of gradle, and gradle now requires at least JDK 17
  • Update docs to reflect the current status (ouch, docs were super-outdated)

@misl6 misl6 force-pushed the fix/use-jdk-17 branch 2 times, most recently from 9cd9856 to 89eba7f Compare November 18, 2023 18:18
@misl6 misl6 changed the title [WIP] Update python-for-android prerequisites (in Dockerfile, docs, CI) Update python-for-android prerequisites (Dockerfile, prerequisites.py, docs) Nov 19, 2023
@misl6 misl6 requested a review from Julian-O November 19, 2023 16:31
@misl6
Copy link
Member Author

misl6 commented Nov 19, 2023

Hi @Julian-O ,
Can you please take a look at docs changes?

AndreMiras
AndreMiras previously approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@misl6 misl6 merged commit 436d5a9 into kivy:develop Nov 20, 2023
@Julian-O
Copy link
Contributor

Should we be mentioning:

  • The need for Cython?
  • The need for Cython<=3?
  • The packages Cython needs? (It needs python3-dev which you have and build-essential which is probably covered by the individual packages, but I am not sure.)

Other than that, looks good.

[Reminder: I think we should be testing on an instance of this Docker, too.]

@Julian-O Julian-O mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

@Julian-O Julian-O Awaiting requested review from Julian-O

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misl6 @Julian-O @AndreMiras