Skip to content

Commit 5a6f6e1

Browse files
[NFC][ScanDependency] Remove some ununsed code
Clean up some code that no longer used.
1 parent aa7ff59 commit 5a6f6e1

File tree

10 files changed

+4
-39
lines changed

10 files changed

+4
-39
lines changed

include/swift/AST/ModuleDependencies.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -992,9 +992,6 @@ class SwiftDependencyScanningService {
992992
/// CAS ObjectStore Instance.
993993
std::shared_ptr<llvm::cas::ObjectStore> CAS;
994994

995-
/// The common dependencies that is needed for every swift compiler instance.
996-
std::vector<std::string> CommonDependencyFiles;
997-
998995
/// File prefix mapper.
999996
std::unique_ptr<llvm::TreePathPrefixMapper> Mapper;
1000997

include/swift/AST/ModuleLoader.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,6 @@ class ModuleLoader {
373373
virtual llvm::SmallVector<std::pair<ModuleDependencyID, ModuleDependencyInfo>, 1>
374374
getModuleDependencies(Identifier moduleName,
375375
StringRef moduleOutputPath,
376-
llvm::IntrusiveRefCntPtr<llvm::cas::CachingOnDiskFileSystem> CacheFS,
377376
const llvm::DenseSet<clang::tooling::dependencies::ModuleID> &alreadySeenClangModules,
378377
clang::tooling::dependencies::DependencyScanningTool &clangScanningTool,
379378
InterfaceSubContextDelegate &delegate,

include/swift/ClangImporter/ClangImporter.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,6 @@ class ClangImporter final : public ClangModuleLoader {
481481

482482
llvm::SmallVector<std::pair<ModuleDependencyID, ModuleDependencyInfo>, 1>
483483
getModuleDependencies(Identifier moduleName, StringRef moduleOutputPath,
484-
llvm::IntrusiveRefCntPtr<llvm::cas::CachingOnDiskFileSystem> CacheFS,
485484
const llvm::DenseSet<clang::tooling::dependencies::ModuleID> &alreadySeenClangModules,
486485
clang::tooling::dependencies::DependencyScanningTool &clangScanningTool,
487486
InterfaceSubContextDelegate &delegate,

include/swift/Sema/SourceLoader.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ class SourceLoader : public ModuleLoader {
100100

101101
llvm::SmallVector<std::pair<ModuleDependencyID, ModuleDependencyInfo>, 1>
102102
getModuleDependencies(Identifier moduleName, StringRef moduleOutputPath,
103-
llvm::IntrusiveRefCntPtr<llvm::cas::CachingOnDiskFileSystem> CacheFS,
104103
const llvm::DenseSet<clang::tooling::dependencies::ModuleID> &alreadySeenClangModules,
105104
clang::tooling::dependencies::DependencyScanningTool &clangScanningTool,
106105
InterfaceSubContextDelegate &delegate,

include/swift/Serialization/SerializedModuleLoader.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,6 @@ class SerializedModuleLoaderBase : public ModuleLoader {
258258

259259
virtual llvm::SmallVector<std::pair<ModuleDependencyID, ModuleDependencyInfo>, 1>
260260
getModuleDependencies(Identifier moduleName, StringRef moduleOutputPath,
261-
llvm::IntrusiveRefCntPtr<llvm::cas::CachingOnDiskFileSystem> CacheFS,
262261
const llvm::DenseSet<clang::tooling::dependencies::ModuleID> &alreadySeenClangModules,
263262
clang::tooling::dependencies::DependencyScanningTool &clangScanningTool,
264263
InterfaceSubContextDelegate &delegate,

lib/AST/ModuleDependencies.cpp

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -691,27 +691,6 @@ bool SwiftDependencyScanningService::setupCachingDependencyScanningService(
691691
CASOpts = Instance.getInvocation().getCASOptions().CASOpts;
692692
CAS = Instance.getSharedCASInstance();
693693

694-
// Add SDKSetting file.
695-
SmallString<256> SDKSettingPath;
696-
llvm::sys::path::append(
697-
SDKSettingPath,
698-
Instance.getInvocation().getSearchPathOptions().getSDKPath(),
699-
"SDKSettings.json");
700-
CommonDependencyFiles.emplace_back(SDKSettingPath.data(),
701-
SDKSettingPath.size());
702-
703-
// Add Legacy layout file (maybe just hard code instead of searching).
704-
for (auto RuntimeLibPath :
705-
Instance.getInvocation().getSearchPathOptions().RuntimeLibraryPaths) {
706-
auto &FS = Instance.getFileSystem();
707-
std::error_code EC;
708-
for (auto F = FS.dir_begin(RuntimeLibPath, EC);
709-
!EC && F != llvm::vfs::directory_iterator(); F.increment(EC)) {
710-
if (F->path().ends_with(".yaml"))
711-
CommonDependencyFiles.emplace_back(F->path().str());
712-
}
713-
}
714-
715694
auto CachingFS =
716695
llvm::cas::createCachingOnDiskFileSystem(Instance.getObjectStore());
717696
if (!CachingFS) {

lib/ClangImporter/ClangModuleDependencyScanner.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,6 @@ computeClangWorkingDirectory(const std::vector<std::string> &commandLineArgs,
421421
ModuleDependencyVector
422422
ClangImporter::getModuleDependencies(Identifier moduleName,
423423
StringRef moduleOutputPath,
424-
llvm::IntrusiveRefCntPtr<llvm::cas::CachingOnDiskFileSystem> CacheFS,
425424
const llvm::DenseSet<clang::tooling::dependencies::ModuleID> &alreadySeenClangModules,
426425
clang::tooling::dependencies::DependencyScanningTool &clangScanningTool,
427426
InterfaceSubContextDelegate &delegate,

lib/DependencyScan/ModuleDependencyScanner.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -218,15 +218,13 @@ ModuleDependencyScanningWorker::scanFilesystemForModuleDependency(
218218
ModuleDependencyVector moduleDependencies =
219219
swiftScannerModuleLoader->getModuleDependencies(
220220
moduleName, cache.getModuleOutputPath(),
221-
cache.getScanService().getCachingFS(),
222221
cache.getAlreadySeenClangModules(), clangScanningTool,
223222
*scanningASTDelegate, cache.getScanService().getPrefixMapper(),
224223
isTestableImport);
225224

226225
if (moduleDependencies.empty())
227226
moduleDependencies = clangScannerModuleLoader->getModuleDependencies(
228227
moduleName, cache.getModuleOutputPath(),
229-
cache.getScanService().getCachingFS(),
230228
cache.getAlreadySeenClangModules(), clangScanningTool,
231229
*scanningASTDelegate, cache.getScanService().getPrefixMapper(),
232230
isTestableImport);
@@ -239,19 +237,17 @@ ModuleDependencyScanningWorker::scanFilesystemForSwiftModuleDependency(
239237
Identifier moduleName, const ModuleDependenciesCache &cache) {
240238
return swiftScannerModuleLoader->getModuleDependencies(
241239
moduleName, cache.getModuleOutputPath(),
242-
cache.getScanService().getCachingFS(), cache.getAlreadySeenClangModules(),
243-
clangScanningTool, *scanningASTDelegate,
244-
cache.getScanService().getPrefixMapper(), false);
240+
cache.getAlreadySeenClangModules(), clangScanningTool,
241+
*scanningASTDelegate, cache.getScanService().getPrefixMapper(), false);
245242
}
246243

247244
ModuleDependencyVector
248245
ModuleDependencyScanningWorker::scanFilesystemForClangModuleDependency(
249246
Identifier moduleName, const ModuleDependenciesCache &cache) {
250247
return clangScannerModuleLoader->getModuleDependencies(
251248
moduleName, cache.getModuleOutputPath(),
252-
cache.getScanService().getCachingFS(), cache.getAlreadySeenClangModules(),
253-
clangScanningTool, *scanningASTDelegate,
254-
cache.getScanService().getPrefixMapper(), false);
249+
cache.getAlreadySeenClangModules(), clangScanningTool,
250+
*scanningASTDelegate, cache.getScanService().getPrefixMapper(), false);
255251
}
256252

257253
template <typename Function, typename... Args>

lib/Sema/SourceLoader.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ void SourceLoader::loadExtensions(NominalTypeDecl *nominal,
157157
ModuleDependencyVector
158158
SourceLoader::getModuleDependencies(Identifier moduleName,
159159
StringRef moduleOutputPath,
160-
llvm::IntrusiveRefCntPtr<llvm::cas::CachingOnDiskFileSystem> CacheFS,
161160
const llvm::DenseSet<clang::tooling::dependencies::ModuleID> &alreadySeenClangModules,
162161
clang::tooling::dependencies::DependencyScanningTool &clangScanningTool,
163162
InterfaceSubContextDelegate &delegate,

lib/Serialization/ScanningLoaders.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,6 @@ SwiftModuleScanner::scanInterfaceFile(Twine moduleInterfacePath,
311311

312312
ModuleDependencyVector SerializedModuleLoaderBase::getModuleDependencies(
313313
Identifier moduleName, StringRef moduleOutputPath,
314-
llvm::IntrusiveRefCntPtr<llvm::cas::CachingOnDiskFileSystem> CacheFS,
315314
const llvm::DenseSet<clang::tooling::dependencies::ModuleID>
316315
&alreadySeenClangModules,
317316
clang::tooling::dependencies::DependencyScanningTool &clangScanningTool,

0 commit comments

Comments
 (0)