Skip to content

Commit 15e74b9

Browse files
committed
fixup! fixup! fixup! fixup! fixup! fix(cache): update cache with O(1) data structures
1 parent 8cf1660 commit 15e74b9

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/cache.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,8 @@ export function deleteItems<T extends KubernetesObject>(
255255
export function addOrUpdateObject<T extends KubernetesObject>(
256256
objects: CacheMap<T>,
257257
obj: T,
258-
addCallback?: Array<ObjectCallback<T>>,
259-
updateCallback?: Array<ObjectCallback<T>>,
258+
addCallbacks?: Array<ObjectCallback<T>>,
259+
updateCallbacks?: Array<ObjectCallback<T>>,
260260
): void {
261261
let namespaceObjects = objects.get(obj.metadata!.namespace || '');
262262
if (!namespaceObjects) {
@@ -268,14 +268,14 @@ export function addOrUpdateObject<T extends KubernetesObject>(
268268
const found = namespaceObjects.get(name);
269269
if (!found) {
270270
namespaceObjects.set(name, obj);
271-
if (addCallback) {
272-
addCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
271+
if (addCallbacks) {
272+
addCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
273273
}
274274
} else {
275275
if (!isSameVersion(found, obj)) {
276276
namespaceObjects.set(name, obj);
277-
if (updateCallback) {
278-
updateCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
277+
if (updateCallbacks) {
278+
updateCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
279279
}
280280
}
281281
}
@@ -293,7 +293,7 @@ function isSameVersion<T extends KubernetesObject>(o1: T, o2: T): boolean {
293293
export function deleteObject<T extends KubernetesObject>(
294294
objects: CacheMap<T>,
295295
obj: T,
296-
deleteCallback?: Array<ObjectCallback<T>>,
296+
deleteCallbacks?: Array<ObjectCallback<T>>,
297297
): void {
298298
const namespace = obj.metadata!.namespace || '';
299299
const name = obj.metadata!.name || '';
@@ -304,8 +304,8 @@ export function deleteObject<T extends KubernetesObject>(
304304
}
305305
const deleted = namespaceObjects.delete(name);
306306
if (deleted) {
307-
if (deleteCallback) {
308-
deleteCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
307+
if (deleteCallbacks) {
308+
deleteCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
309309
}
310310
if (namespaceObjects.size === 0) {
311311
objects.delete(namespace);

0 commit comments

Comments
 (0)