Skip to content

Commit 305c307

Browse files
authored
Merge pull request #1033 from rbnayax/request
fix: remove final refrences to request + fix tests
2 parents fbe3a3a + 6ae196d commit 305c307

File tree

14 files changed

+557
-1045
lines changed

14 files changed

+557
-1045
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
runs-on: ubuntu-latest
1212
strategy:
1313
matrix:
14-
node: [ '16', '14', '12' ]
14+
node: [ '18', '16', '14', '12' ]
1515
name: Node ${{ matrix.node }} validation
1616
steps:
1717
- uses: actions/checkout@v2

FETCH_MIGRATION.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ Code will be on the `master` branch.
5151
- [x] Match src/gen/api.ts to new generated layout (it changes slightly)
5252
- [ ] Fix errors in /src folder (due to new api)
5353
- [x] migrate src/auth.ts, the dependent implementations (ex: azure_auth, gcp_auth etc) and tests to fetch api from request
54-
- [ ] migrate src/log.ts and its tests to fetch api from request
55-
- major remaining work is fixing up async signatures and return piping
56-
- [ ] migrate src/watch.ts and its tests to fetch api from request
57-
- remove decprecated requestImpl and RequestInterface
58-
- implement queryParams parameter in watch method by injecting them into the fetch call
59-
- update tests in src/watch_test.ts
54+
- [x] migrate src/log.ts and its tests to fetch api from request
55+
- [x] major remaining work is fixing up async signatures and return piping
56+
- [x] migrate src/watch.ts and its tests to fetch api from request
57+
- [x] remove decprecated requestImpl and RequestInterface
58+
- [x] implement queryParams parameter in watch method by injecting them into the fetch call
59+
- [x] update tests in src/watch_test.ts
6060
- [ ] Fix errors in test (due to new api)
6161
- [ ] Test all features
6262
- [ ] Fix examples and validate their param signatures (due to new api)

0 commit comments

Comments
 (0)