Skip to content

Commit 7eea087

Browse files
committed
fixup! fixup! fixup! fixup! fixup! fix(cache): update cache with O(1) data structures
1 parent 6c3c89d commit 7eea087

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/cache.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,8 @@ export function deleteItems<T extends KubernetesObject>(
264264
export function addOrUpdateObject<T extends KubernetesObject>(
265265
objects: CacheMap<T>,
266266
obj: T,
267-
addCallback?: Array<ObjectCallback<T>>,
268-
updateCallback?: Array<ObjectCallback<T>>,
267+
addCallbacks?: Array<ObjectCallback<T>>,
268+
updateCallbacks?: Array<ObjectCallback<T>>,
269269
): void {
270270
let namespaceObjects = objects.get(obj.metadata!.namespace || '');
271271
if (!namespaceObjects) {
@@ -277,14 +277,14 @@ export function addOrUpdateObject<T extends KubernetesObject>(
277277
const found = namespaceObjects.get(name);
278278
if (!found) {
279279
namespaceObjects.set(name, obj);
280-
if (addCallback) {
281-
addCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
280+
if (addCallbacks) {
281+
addCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
282282
}
283283
} else {
284284
if (!isSameVersion(found, obj)) {
285285
namespaceObjects.set(name, obj);
286-
if (updateCallback) {
287-
updateCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
286+
if (updateCallbacks) {
287+
updateCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
288288
}
289289
}
290290
}
@@ -302,7 +302,7 @@ function isSameVersion<T extends KubernetesObject>(o1: T, o2: T): boolean {
302302
export function deleteObject<T extends KubernetesObject>(
303303
objects: CacheMap<T>,
304304
obj: T,
305-
deleteCallback?: Array<ObjectCallback<T>>,
305+
deleteCallbacks?: Array<ObjectCallback<T>>,
306306
): void {
307307
const namespace = obj.metadata!.namespace || '';
308308
const name = obj.metadata!.name || '';
@@ -313,8 +313,8 @@ export function deleteObject<T extends KubernetesObject>(
313313
}
314314
const deleted = namespaceObjects.delete(name);
315315
if (deleted) {
316-
if (deleteCallback) {
317-
deleteCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
316+
if (deleteCallbacks) {
317+
deleteCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
318318
}
319319
if (namespaceObjects.size === 0) {
320320
objects.delete(namespace);

0 commit comments

Comments
 (0)