Skip to content

Examples improvements #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Examples improvements #1164

merged 1 commit into from
Jul 14, 2023

Conversation

DavidIsa
Copy link

I suggest some improvements to the examples

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 12, 2023
@brendandburns
Copy link
Contributor

Thanks for the PR

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, DavidIsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 278e306 into kubernetes-client:master Jul 14, 2023
@arimgibson
Copy link

For whatever reason, the watch example no longer functions after this change. The code looks fine to me as well, but the watch method no longer reports anything nor does it call the done function after running.

The example before this PR works as expected. I'm happy to look into it more next week when I have some availability if the fix isn't clear before then. Also happy to open a new issue if that makes more sense too; again it might have to be next week though to make sure I can complete it with all the details!

@arimgibson
Copy link

arimgibson commented Jul 30, 2023

Nvm, super simple fix. The call to watch.watch() shouldn't be awaited. I can submit a quick PR next week if someone doesn't get to it before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants