makeInformer returns Informer & ObjectCache #818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeInformer currently returns the ListWatch object implements Informer interface.
In addition that, it also implements ObjectCache interface.
ObjectCache is very useful to implements kubernetes controller, but to use ObjectCache methods, we can't achieve the benefit of typescript type checking, because makeInformer returns the value as Informer interface.
In this PR, makeInformer returns the value as Informer & ObjectCache in order to accurate the typescript type check.
Maybe we should define new interface for that.