-
Notifications
You must be signed in to change notification settings - Fork 551
Add comment about patching custom resources on apply example #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When running a `patch` operation on a custom resource the default strategic merge strategy can fail. Since it's difficult to identify custom resources, we leave a note to the developer that they need to be aware of this when using this example code. See: kubernetes-client#838
|
Welcome @dominic-p! |
/lgtm |
@dominic-p looks like CI/CD is failing. |
It looks like one of the lines was a bit too long. It should be good to go now. |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, dominic-p The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When running a
patch
operation on a custom resource the default strategic merge strategy can fail. Since it's difficult to identify custom resources, we leave a note to the developer that they need to be aware of this when using this example code.See: #838