Skip to content

fix: update gen commit to fix error with dubious repo #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

clintonmedbery
Copy link
Contributor

When trying to run generate, you get an error:

/source/openapi-generator /
fatal: detected dubious ownership in repository at '/source/openapi-generator'
To add an exception for this directory, call:

	git config --global --add safe.directory /source/openapi-generator

Upstream 🧵: kubernetes-client/gen#236
Upstream Fix: kubernetes-client/gen#237

This is a simple fix to update the commit hash and include that fix in this repo.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2023
@clintonmedbery
Copy link
Contributor Author

Is there a reason we wouldn't want to update this?

@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks, this is good to fix.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, clintonmedbery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3e58c8d into kubernetes-client:master Feb 24, 2023
@clintonmedbery clintonmedbery deleted the clintonmedbery/fix/update-gen-commit-fix-dubious-repo branch March 1, 2023 19:10
@clintonmedbery clintonmedbery restored the clintonmedbery/fix/update-gen-commit-fix-dubious-repo branch March 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants