Skip to content

Commit 2883e1f

Browse files
authored
Fix documentation: using numerical target ports in services doesn't cause downtime (#1658)
The actual issue was fixed in #1635.
1 parent 03986db commit 2883e1f

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

docs/guide/upgrade/migrate_v1_v2.md

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,13 @@ This document contains the information necessary to migrate from an existing ins
99

1010

1111
## Backwards compatibility
12-
The AWSLoadBalancerController(v2.0.0) is backwards-compatible with AWSALBIngressController(>=v1.1.3).
12+
The AWSLoadBalancerController(v2.0.1) is backwards-compatible with AWSALBIngressController(>=v1.1.3).
1313

1414
It supports existing AWS resources provisioned by AWSALBIngressController(>=v1.1.3) for Ingress resources with below caveats:
1515

1616
1. The AWS LoadBalancer resource created for your Ingress will be preserved.
17-
18-
2. If a numeric TargetPort is used in your service, the AWS TargetGroups created for your Ingress will be re-created.
19-
20-
!!!warning "downtimes"
21-
This would cause downtimes to your service during targets registration into new TargetGroups created.
22-
23-
!!!tip "details"
24-
* The AWSALBIngressController always used `1` as TargetGroup's port.
25-
* The AWSLoadBalancerController will use
26-
* the actual numeric TargetPort as TargetGroup's port if a numeric TargetPort used.
27-
* `1` as TargetGroup's port if a lexical TargetPort used.
28-
* The AWSLoadBalancerController will automatically create new TargetGroups and cleanup old TargetGroups if any.
2917

30-
3. If [security-groups](../../guide/ingress/annotations.md#security-groups) annotation isn't used, the SecurityGroup rule on worker node's SecurityGroup that allow LoadBalancer traffic should be manually adjusted post migration.
18+
2. If [security-groups](../../guide/ingress/annotations.md#security-groups) annotation isn't used, the SecurityGroup rule on worker node's SecurityGroup that allow LoadBalancer traffic should be manually adjusted post migration.
3119

3220
!!!tip "details"
3321
when [security-groups](../../guide/ingress/annotations.md#security-groups) annotation isn't used:
@@ -51,7 +39,7 @@ It supports existing AWS resources provisioned by AWSALBIngressController(>=v1.1
5139
|--------|----------|----------|---------------------------|----------------------|
5240
|All TCP |TCP |0 - 65535 |sg-008c920b1(managed LB SG)|elbv2.k8s.aws/targetGroupBinding=shared| |
5341

54-
4. If you have used podReadinessGate feature, please refer [PodReadinessGate](../controller/pod_readiness_gate.md) for the guide about new readinessGate configuration.
42+
3. If you have used podReadinessGate feature, please refer [PodReadinessGate](../controller/pod_readiness_gate.md) for the guide about new readinessGate configuration.
5543

5644
!!!tip "old pod readinessGate"
5745
once configured properly, AWS Load Balancer Controller will automatically inject the new format of podReadinessGates into your pods, and remove old podReadinessGates if any.
@@ -76,4 +64,4 @@ foo@bar:~$ kubectl describe deployment -n kube-system alb-ingress-controller |
7664
1. Install AWSLoadBalancerController(v2.0.0) by following the [installation instructions](../controller/installation.md)
7765
2. Grant [additional IAM policy](../../install/iam_policy_v1_to_v2_additional.json) needed for migration to the controller.
7866

79-
4. Verify all Ingresses works as expected.
67+
4. Verify all Ingresses works as expected.

0 commit comments

Comments
 (0)