Skip to content

Commit 3d631b0

Browse files
committed
put the FindUnusedTGs deletion back in
1 parent 0db7afa commit 3d631b0

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

pkg/alb/lb/loadbalancer.go

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,12 @@ func (l *LoadBalancer) Reconcile(rOpts *ReconcileOptions) []error {
353353
l.listeners = ltnrs
354354
}
355355

356+
// Decide: Is this still needed?
357+
for _, listener := range l.listeners {
358+
unusedTGs := listener.GetRules().FindUnusedTGs(l.targetgroups)
359+
unusedTGs.StripDesiredState()
360+
}
361+
356362
tgsOpts.IgnoreDeletes = false
357363
tgs, err = l.targetgroups.Reconcile(tgsOpts)
358364
if err != nil {
@@ -361,19 +367,6 @@ func (l *LoadBalancer) Reconcile(rOpts *ReconcileOptions) []error {
361367
l.targetgroups = tgs
362368
}
363369

364-
// Decide: Is this still needed?
365-
// for _, listener := range l.listeners {
366-
// unusedTGs := listener.GetRules().FindUnusedTGs(l.targetgroups)
367-
// for _, t := range unusedTGs {
368-
// if err := albelbv2.ELBV2svc.RemoveTargetGroup(t.CurrentARN()); err != nil {
369-
// errors = append(errors, err)
370-
// continue
371-
// }
372-
// index, _ := l.targetgroups.FindById(t.ID)
373-
// l.targetgroups = append(l.targetgroups[:index], l.targetgroups[index+1:]...)
374-
// }
375-
// }
376-
377370
return errors
378371
}
379372

0 commit comments

Comments
 (0)