Add detailed comments for tests

Shreya027 · web-flow · commit 432edbd6cf41 · 2021-08-05T23:16:30.000-07:00
diff --git a/pkg/deploy/elbv2/tagging_manager_test.go b/pkg/deploy/elbv2/tagging_manager_test.go
@@ -266,7 +266,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {
 		wantErr error
 	}{
 		{
-			name: "2/3 loadBalancers matches single tagFilter",
+			name: "2/3 loadBalancers matches single tagFilter; 0 loadBalancers filtered out on VPC ID",
 			fields: fields{
 				describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{
 					{
@@ -363,7 +363,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {
 			},
 		},
 		{
-			name: "1/3 loadBalancers matches single tagFilter",
+			name: "1/3 loadBalancers matches single tagFilter; 1 loadBalancer filtered out on VPC ID",
 			fields: fields{
 				describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{
 					{
@@ -440,7 +440,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {
 			},
 		},
 		{
-			name: "1/3 loadBalancers matches single tagFilter",
+			name: "1/3 loadBalancers matches single tagFilter; 2 loadBalancers filtered out on VPC ID",
 			fields: fields{
 				describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{
 					{
@@ -504,7 +504,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {
 			},
 		},
 		{
-			name: "0/3 loadBalancers matches single tagFilter",
+			name: "0/3 loadBalancers matches single tagFilter; 0 loadBalancers filtered out on VPC ID",
 			fields: fields{
 				describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{
 					{
@@ -640,7 +640,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {
 		wantErr error
 	}{
 		{
-			name: "2/3 targetGroups matches single tagFilter",
+			name: "2/3 targetGroups matches single tagFilter; 0 targetGroups filtered out on VPC ID",
 			fields: fields{
 				describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{
 					{
@@ -737,7 +737,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {
 			},
 		},
 		{
-			name: "1/3 targetGroups matches single tagFilter",
+			name: "1/3 targetGroups matches single tagFilter; 1 targetGroup filtered out on VPC ID",
 			fields: fields{
 				describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{
 					{
@@ -814,7 +814,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {
 			},
 		},
 		{
-			name: "1/3 targetGroups matches single tagFilter",
+			name: "1/3 targetGroups matches single tagFilter; 2 targetGroups filtered out on VPC ID",
 			fields: fields{
 				describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{
 					{
@@ -878,7 +878,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {
 			},
 		},
 		{
-			name: "0/3 targetGroups matches single tagFilter",
+			name: "0/3 targetGroups matches single tagFilter; 0 targetGroups filtered out on VPC ID",
 			fields: fields{
 				describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{
 					{

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {`
`266`	`266`	`wantErr error`
`267`	`267`	`}{`
`268`	`268`	`{`
`269`		`- name: "2/3 loadBalancers matches single tagFilter",`
	`269`	`+ name: "2/3 loadBalancers matches single tagFilter; 0 loadBalancers filtered out on VPC ID",`
`270`	`270`	`fields: fields{`
`271`	`271`	`describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{`
`272`	`272`	`{`
`@@ -363,7 +363,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {`
`363`	`363`	`},`
`364`	`364`	`},`
`365`	`365`	`{`
`366`		`- name: "1/3 loadBalancers matches single tagFilter",`
	`366`	`+ name: "1/3 loadBalancers matches single tagFilter; 1 loadBalancer filtered out on VPC ID",`
`367`	`367`	`fields: fields{`
`368`	`368`	`describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{`
`369`	`369`	`{`
`@@ -440,7 +440,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {`
`440`	`440`	`},`
`441`	`441`	`},`
`442`	`442`	`{`
`443`		`- name: "1/3 loadBalancers matches single tagFilter",`
	`443`	`+ name: "1/3 loadBalancers matches single tagFilter; 2 loadBalancers filtered out on VPC ID",`
`444`	`444`	`fields: fields{`
`445`	`445`	`describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{`
`446`	`446`	`{`
`@@ -504,7 +504,7 @@ func Test_defaultTaggingManager_ListLoadBalancers(t *testing.T) {`
`504`	`504`	`},`
`505`	`505`	`},`
`506`	`506`	`{`
`507`		`- name: "0/3 loadBalancers matches single tagFilter",`
	`507`	`+ name: "0/3 loadBalancers matches single tagFilter; 0 loadBalancers filtered out on VPC ID",`
`508`	`508`	`fields: fields{`
`509`	`509`	`describeLoadBalancersAsListCalls: []describeLoadBalancersAsListCall{`
`510`	`510`	`{`
`@@ -640,7 +640,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {`
`640`	`640`	`wantErr error`
`641`	`641`	`}{`
`642`	`642`	`{`
`643`		`- name: "2/3 targetGroups matches single tagFilter",`
	`643`	`+ name: "2/3 targetGroups matches single tagFilter; 0 targetGroups filtered out on VPC ID",`
`644`	`644`	`fields: fields{`
`645`	`645`	`describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{`
`646`	`646`	`{`
`@@ -737,7 +737,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {`
`737`	`737`	`},`
`738`	`738`	`},`
`739`	`739`	`{`
`740`		`- name: "1/3 targetGroups matches single tagFilter",`
	`740`	`+ name: "1/3 targetGroups matches single tagFilter; 1 targetGroup filtered out on VPC ID",`
`741`	`741`	`fields: fields{`
`742`	`742`	`describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{`
`743`	`743`	`{`
`@@ -814,7 +814,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {`
`814`	`814`	`},`
`815`	`815`	`},`
`816`	`816`	`{`
`817`		`- name: "1/3 targetGroups matches single tagFilter",`
	`817`	`+ name: "1/3 targetGroups matches single tagFilter; 2 targetGroups filtered out on VPC ID",`
`818`	`818`	`fields: fields{`
`819`	`819`	`describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{`
`820`	`820`	`{`
`@@ -878,7 +878,7 @@ func Test_defaultTaggingManager_ListTargetGroups(t *testing.T) {`
`878`	`878`	`},`
`879`	`879`	`},`
`880`	`880`	`{`
`881`		`- name: "0/3 targetGroups matches single tagFilter",`
	`881`	`+ name: "0/3 targetGroups matches single tagFilter; 0 targetGroups filtered out on VPC ID",`
`882`	`882`	`fields: fields{`
`883`	`883`	`describeTargetGroupsAsListCalls: []describeTargetGroupsAsListCall{`
`884`	`884`	`{`