Skip to content

Commit 580134b

Browse files
hawkesnkishorj
andauthored
Explicitly setting CertManager APIVersion to V1 (#3189)
* Allow specifying apiVersion for CertManager * feat: Use certmanager v1 * fix: remove values.yaml option for certmanager * Update helm/aws-load-balancer-controller/README.md --------- Co-authored-by: Kishor Joshi <[email protected]>
1 parent fb9176d commit 580134b

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

helm/aws-load-balancer-controller/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ kubectl apply -k "github.com/aws/eks-charts/stable/aws-load-balancer-controller/
8282

8383
If you are setting `enableCertManager: true` you need to have installed cert-manager and it's CRDs before installing this chart; to install [cert-manager](https://artifacthub.io/packages/helm/cert-manager/cert-manager) follow the installation guide.
8484

85+
The controller helm chart requires the cert-manager with apiVersion `cert-manager.io/v1`.
86+
8587
Set `cluster.dnsDomain` (default: `cluster.local`) to the actual DNS domain of your cluster to include the FQDN in requested TLS certificates.
8688

8789
#### Installing the Prometheus Operator

helm/aws-load-balancer-controller/templates/webhook.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -212,11 +212,7 @@ data:
212212
tls.crt: {{ $tls.clientCert }}
213213
tls.key: {{ $tls.clientKey }}
214214
{{- else }}
215-
{{- if .Capabilities.APIVersions.Has "cert-manager.io/v1" }}
216215
apiVersion: cert-manager.io/v1
217-
{{- else }}
218-
apiVersion: cert-manager.io/v1alpha2
219-
{{- end }}
220216
kind: Certificate
221217
metadata:
222218
name: {{ template "aws-load-balancer-controller.namePrefix" . }}-serving-cert
@@ -232,11 +228,7 @@ spec:
232228
name: {{ template "aws-load-balancer-controller.namePrefix" . }}-selfsigned-issuer
233229
secretName: {{ template "aws-load-balancer-controller.webhookCertSecret" . }}
234230
---
235-
{{- if .Capabilities.APIVersions.Has "cert-manager.io/v1" }}
236231
apiVersion: cert-manager.io/v1
237-
{{- else }}
238-
apiVersion: cert-manager.io/v1alpha2
239-
{{- end }}
240232
kind: Issuer
241233
metadata:
242234
name: {{ template "aws-load-balancer-controller.namePrefix" . }}-selfsigned-issuer

0 commit comments

Comments
 (0)