Wasn't removing deleted targetgroups from the list

Author: bigkraig

pkg/alb/lb/loadbalancer.go

@@ -338,9 +338,9 @@ func (l *LoadBalancer) Reconcile(rOpts *ReconcileOptions) []error {
 	tgs, err := l.targetgroups.Reconcile(tgsOpts)
 	if err != nil {
 		errors = append(errors, err)
-		return errors
+	} else {
+		l.targetgroups = tgs
 	}
-	l.targetgroups = tgs
 
 	lsOpts := &ls.ReconcileOptions{
 		Eventf:          rOpts.Eventf,
@@ -357,9 +357,9 @@ func (l *LoadBalancer) Reconcile(rOpts *ReconcileOptions) []error {
 	tgs, err = l.targetgroups.Reconcile(tgsOpts)
 	if err != nil {
 		errors = append(errors, err)
-		return errors
+	} else {
+		l.targetgroups = tgs
 	}
-	l.targetgroups = tgs
 
 	// Decide: Is this still needed?
 	// for _, listener := range l.listeners {

pkg/alb/tg/targetgroups.go

@@ -55,7 +55,10 @@ func (t TargetGroups) Reconcile(rOpts *ReconcileOptions) (TargetGroups, error) {
 		if err := tg.Reconcile(rOpts); err != nil {
 			return nil, err
 		}
-		output = append(output, tg)
+
+		if !tg.deleted {
+			output = append(output, tg)
+		}
 	}
 
 	return output, nil