fix multiple cert arns in service annotation (#1503)

kishorj · web-flow · commit 89b15a3a3238 · 2020-10-14T16:48:12.000-07:00
diff --git a/pkg/service/nlb/builder.go b/pkg/service/nlb/builder.go
@@ -435,7 +435,7 @@ func (t *defaultModelBuildTask) buildListeners(ctx context.Context, ec2Subnets [
 		var certificates []elbv2model.Certificate
 		if listenerProtocol == elbv2model.ProtocolTLS {
 			for _, cert := range certificateARNs {
-				certificates = append(certificates, elbv2model.Certificate{CertificateARN: &cert})
+				certificates = append(certificates, elbv2model.Certificate{CertificateARN: aws.String(cert)})
 			}
 		}
 
diff --git a/pkg/service/nlb/builder_test.go b/pkg/service/nlb/builder_test.go
@@ -508,7 +508,7 @@ func Test_defaultModelBuilderTask_buildNLB(t *testing.T) {
                ],
                "certificates":[
                   {
-                     "certificateARN":"certArn2"
+                     "certificateARN":"certArn1"
                   },
                   {
                      "certificateARN":"certArn2"

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,7 @@ func (t *defaultModelBuildTask) buildListeners(ctx context.Context, ec2Subnets [`
`435`	`435`	`var certificates []elbv2model.Certificate`
`436`	`436`	`if listenerProtocol == elbv2model.ProtocolTLS {`
`437`	`437`	`for _, cert := range certificateARNs {`
`438`		`- certificates = append(certificates, elbv2model.Certificate{CertificateARN: &cert})`
	`438`	`+ certificates = append(certificates, elbv2model.Certificate{CertificateARN: aws.String(cert)})`
`439`	`439`	`}`
`440`	`440`	`}`
`441`	`441`
Original file line number	Diff line number	Diff line change
`@@ -508,7 +508,7 @@ func Test_defaultModelBuilderTask_buildNLB(t *testing.T) {`
`508`	`508`	`],`
`509`	`509`	`"certificates":[`
`510`	`510`	`{`
`511`		`- "certificateARN":"certArn2"`
	`511`	`+ "certificateARN":"certArn1"`
`512`	`512`	`},`
`513`	`513`	`{`
`514`	`514`	`"certificateARN":"certArn2"`