Skip to content

Commit a789f51

Browse files
authored
update docs for deletion_protection (#2181)
1 parent 5978177 commit a789f51

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

docs/guide/ingress/annotations.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -652,9 +652,10 @@ Custom attributes to LoadBalancers and TargetGroups can be controlled with follo
652652
!!!warning ""
653653
Only attributes defined in the annotation will be updated. To unset any AWS defaults(e.g. Disabling access logs after having them enabled once), the values need to be explicitly set to the original values(`access_logs.s3.enabled=false`) and omitting them is not sufficient.
654654

655-
!!!note ""
656-
If deletion protection is enabled, the controller will not be able to delete the ALB during reconciliation.
657-
655+
!!!note ""
656+
- If `deletion_protection.enable=true` is in annotation, the controller will not be able to delete the ALB during reconciliation. Once the attribute gets edited to `deletion_protection.enable=false` during reconciliation, the deployer will force delete the resource.
657+
- Please note, if the deletion protection is not enabled via annotation (e.g. via AWS console), the controller still deletes the underlying resource.
658+
658659
!!!example
659660
- enable access log to s3
660661
```

docs/guide/service/annotations.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,11 @@ for proxy protocol v2 configuration.
177177
!!!warning ""
178178
Only attributes defined in the annotation will be updated. To unset any AWS defaults(e.g. Disabling access logs after having them enabled once), the values need to be explicitly set to the original values(`access_logs.s3.enabled=false`) and omitting them is not sufficient.
179179
Custom attributes set in this annotation's config map will be overriden by annotation-specific attributes. For backwards compatibility, existing annotations for the individual load balancer attributes get precedence in case of ties.
180-
180+
181+
!!!note ""
182+
- If `deletion_protection.enable=true` is in annotation, the controller will not be able to delete the NLB during reconciliation. Once the attribute gets edited to `deletion_protection.enable=false` during reconciliation, the deployer will force delete the resource.
183+
- Please note, if the deletion protection is not enabled via annotation (e.g. via AWS console), the controller still deletes the underlying resource.
184+
181185
!!!example
182186
- enable access log to s3
183187
```

0 commit comments

Comments
 (0)