Merge pull request #648 from M00nF1sh/fix_625

Fix bug as in #625

Author: k8s-ci-robot

internal/alb/lb/loadbalancer.go

@@ -270,6 +270,9 @@ func (l *LoadBalancer) Reconcile(rOpts *ReconcileOptions) []error {
 		l.listeners = ltnrs
 	}
 
+	// TODO: currently this works fine since every listener get same actions,
+	// when this precondition don't hold, we need to consider deletion at cross-listener level.
+
 	// Does not consider TG used for listener default action
 	for _, listener := range l.listeners {
 		unusedTGs := listener.GetRules().FindUnusedTGs(l.targetgroups, listener.DefaultActionArn())

internal/alb/ls/listener.go

@@ -336,7 +336,7 @@ func (l *Listener) DefaultActionArn() *string {
 	if l.ls.current == nil || len(l.ls.current.DefaultActions) < 1 || l.ls.current.DefaultActions[0].Type == nil {
 		return nil
 	}
-	if *l.ls.current.DefaultActions[0].Type == elbv2.ActionTypeEnumRedirect {
+	if *l.ls.current.DefaultActions[0].Type == elbv2.ActionTypeEnumForward {
 		return l.ls.current.DefaultActions[0].TargetGroupArn
 	}
 	return nil

internal/alb/tg/targetgroups.go

@@ -119,11 +119,17 @@ func NewDesiredTargetGroups(o *NewDesiredTargetGroupsOptions) (TargetGroups, err
 	}
 
 	var targetGroupsInUse TargetGroups
+	backendsProcessed := make(map[string]bool)
 	for _, backend := range backends {
 		if action.Use(backend.ServicePort.String()) {
 			// action annotations do not need target groups
 			continue
 		}
+		backendName := backend.ServiceName + ":" + backend.ServicePort.String()
+		if _, ok := backendsProcessed[backendName]; ok {
+			continue
+		}
+		backendsProcessed[backendName] = true
 
 		targetGroup, err := NewDesiredTargetGroupFromBackend(&NewDesiredTargetGroupFromBackendOptions{
 			Backend:              backend,