Skip to content

Commit e7656b6

Browse files
committed
fix unit test
1 parent cc1c597 commit e7656b6

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ require (
2020
github.com/imdario/mergo v0.3.7
2121
github.com/json-iterator/go v1.1.5 // indirect
2222
github.com/magiconair/properties v1.8.0
23+
github.com/mattn/goveralls v0.0.3-0.20190325144123-900af2b6e486 // indirect
2324
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
2425
github.com/modern-go/reflect2 v1.0.1 // indirect
2526
github.com/onsi/ginkgo v1.7.0

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ github.com/mattn/go-colorable v0.0.9/go.mod h1:9vuHe8Xs5qXnSaW/c/ABM9alt+Vo+STaO
141141
github.com/mattn/go-isatty v0.0.3 h1:ns/ykhmWi7G9O+8a448SecJU3nSMBXJfqQkl0upE1jI=
142142
github.com/mattn/go-isatty v0.0.3/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4=
143143
github.com/mattn/goveralls v0.0.2/go.mod h1:8d1ZMHsd7fW6IRPKQh46F2WRpyib5/X4FOpevwGNQEw=
144+
github.com/mattn/goveralls v0.0.3-0.20190325144123-900af2b6e486 h1:Wm8cZ6zwoV7jgpZl3YUSw+3Nx9BIaIQAVBCdvSZuweM=
145+
github.com/mattn/goveralls v0.0.3-0.20190325144123-900af2b6e486/go.mod h1:8d1ZMHsd7fW6IRPKQh46F2WRpyib5/X4FOpevwGNQEw=
144146
github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0jegS5sx/RkqARlsWZ6pIwiU=
145147
github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
146148
github.com/mitchellh/go-homedir v1.0.0 h1:vKb8ShqSby24Yrqr/yDYkuFz8d0WUjys40rvnGC8aR0=

scripts/ci_unit_test.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ set -e
44
COVER_PROFILE=profile.cov
55

66
report_coverage() {
7-
go get github.com/mattn/goveralls
8-
CIRCLE_BUILD_NUM=${BUILD_ID} CIRCLE_PR_NUMBER=${PULL_NUMBER} $(go env GOBIN)/goveralls \
7+
go install -v github.com/mattn/goveralls
8+
# need to override prow's BUILD_NUMBER to "" so it won't be reported as jobID to avoid 5xx error :D
9+
BUILD_NUMBER="" PULL_REQUEST_NUMBER=${PULL_NUMBER} $GOBIN/goveralls \
910
-coverprofile=$COVER_PROFILE \
1011
-service=prow \
1112
-repotoken $(cat /etc/coveralls-token/k8s-aws-alb-ingress-coveralls-token) \

0 commit comments

Comments
 (0)