Skip to content

Commit f3a9742

Browse files
author
Carlos Flores
committed
use string for wantErr
1 parent ca8a02f commit f3a9742

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

pkg/targetgroupbinding/networking_manager_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1435,7 +1435,7 @@ func Test_defaultNetworkingManager_resolveEndpointSGForENI(t *testing.T) {
14351435
fields fields
14361436
args args
14371437
want string
1438-
wantErr error
1438+
wantErr string
14391439
}{
14401440
{
14411441
name: "Only one security group in eniInfo returns early",
@@ -1470,7 +1470,7 @@ func Test_defaultNetworkingManager_resolveEndpointSGForENI(t *testing.T) {
14701470
},
14711471
},
14721472
want: "",
1473-
wantErr: errors.New("expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a for eni eni-a, got: [] (clusterName: cluster-a)"),
1473+
wantErr: "expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a for eni eni-a, got: [] (clusterName: cluster-a)",
14741474
},
14751475
{
14761476
name: "A single security group with cluster name tag and no service target tags set",
@@ -1585,7 +1585,7 @@ func Test_defaultNetworkingManager_resolveEndpointSGForENI(t *testing.T) {
15851585
},
15861586
},
15871587
want: "",
1588-
wantErr: errors.New("expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a and map[keyA:valueNotA] for eni eni-a, got: [] (clusterName: cluster-a)"),
1588+
wantErr: "expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a and map[keyA:valueNotA] for eni eni-a, got: [] (clusterName: cluster-a)",
15891589
},
15901590
{
15911591
name: "A single security group with cluster name tag and multiple service target tags set",
@@ -1666,7 +1666,7 @@ func Test_defaultNetworkingManager_resolveEndpointSGForENI(t *testing.T) {
16661666
},
16671667
},
16681668
want: "",
1669-
wantErr: errors.New("expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a and map[keyA:valueA keyB:valueNotB2] for eni eni-a, got: [] (clusterName: cluster-a)"),
1669+
wantErr: "expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a and map[keyA:valueA keyB:valueNotB2] for eni eni-a, got: [] (clusterName: cluster-a)",
16701670
},
16711671
{
16721672
name: "A single security group with cluster name tag and a service target tags with an empty value",
@@ -1745,7 +1745,7 @@ func Test_defaultNetworkingManager_resolveEndpointSGForENI(t *testing.T) {
17451745
},
17461746
},
17471747
want: "",
1748-
wantErr: errors.New("expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a and map[keyE:] for eni eni-a, got: [] (clusterName: cluster-a)"),
1748+
wantErr: "expected exactly one securityGroup tagged with kubernetes.io/cluster/cluster-a and map[keyE:] for eni eni-a, got: [] (clusterName: cluster-a)",
17491749
},
17501750
}
17511751
for _, tt := range tests {
@@ -1764,8 +1764,8 @@ func Test_defaultNetworkingManager_resolveEndpointSGForENI(t *testing.T) {
17641764
serviceTargetENISGTags: tt.fields.serviceTargetENISGTags,
17651765
}
17661766
got, err := m.resolveEndpointSGForENI(tt.args.ctx, tt.args.eniInfo)
1767-
if tt.wantErr != nil {
1768-
assert.EqualError(t, err, tt.wantErr.Error())
1767+
if tt.wantErr != "" {
1768+
assert.EqualError(t, err, tt.wantErr)
17691769
} else {
17701770
assert.NoError(t, err)
17711771
assert.Equal(t, tt.want, got)

0 commit comments

Comments
 (0)