Skip to content

Commit f736deb

Browse files
froblesmartinsehkishorj
authored
chore: clarify how to get internal NLB (#2356)
* chore: specify how to get classic nlb type Adding clarifications about the current annotation "service.beta.kubernetes.io/aws-load-balancer-type: external" as it sounds confusing and does not show that an "internal" NLB can be achieved using that type. * Move deprecation note to line start * add tip about provisioning internal lb * fix: only nlb can be provisioned * chore: change to Internet-facing Co-authored-by: Steven E. Harris <[email protected]> * Update docs/guide/service/annotations.md * Update docs/guide/service/annotations.md * Update docs/guide/service/annotations.md Co-authored-by: Steven E. Harris <[email protected]> Co-authored-by: Steven E. Harris <[email protected]> Co-authored-by: Kishor Joshi <[email protected]>
1 parent 8bd25d2 commit f736deb

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

docs/guide/service/annotations.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,12 @@ Traffic Routing can be controlled with following annotations:
6262

6363
- <a name="lb-type">`service.beta.kubernetes.io/aws-load-balancer-type`</a> specifies the load balancer type. This controller reconciles those service resources with this annotation set to either `nlb-ip` or `external`.
6464

65+
!!!tip
66+
This annotation specifies the controller used to provision LoadBalancers (as specified in [legacy-cloud-provider](#legacy-cloud-provider)). Refer to [lb-scheme](#lb-scheme) to specify whether the LoadBalancer is internet-facing or internal.
67+
6568
!!!note ""
66-
- For `nlb-ip` type, controller will provision NLB with IP targets. This value is supported for backwards compatibility
67-
- For `external` type, NLB target type depend on the annotation [nlb-target-type](#nlb-target-type)
69+
- [Deprecated] For type `nlb-ip`, the controller will provision an NLB with targets registered by IP address. This value is supported for backwards compatibility.
70+
- For type `external`, the NLB target type depends on the [nlb-target-type](#nlb-target-type) annotation.
6871

6972
!!!warning "limitations"
7073
- This annotation should not be modified after service creation.

0 commit comments

Comments
 (0)