Skip to content

Commit fb4666d

Browse files
committed
Added some listner needsModification debug info and removed some unnecessary hostname debugs
1 parent b2f004a commit fb4666d

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

pkg/alb/ls/listener.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ func (l *Listener) Reconcile(rOpts *ReconcileOptions) error {
9494
return err
9595
}
9696
rOpts.Eventf(api.EventTypeNormal, "MODIFY", "%v listener modified", *l.ls.current.Port)
97-
l.logger.Infof("Completed Listener modification. ARN: %s | Port: %s | Proto: %s.",
97+
l.logger.Infof("Completed Listener modification. ARN: %s | Port: %v | Proto: %s.",
9898
*l.ls.current.ListenerArn, *l.ls.current.Port, *l.ls.current.Protocol)
9999

100100
default:
@@ -200,16 +200,22 @@ func (l *Listener) needsModification(rOpts *ReconcileOptions) bool {
200200
case lsc == nil && lsd == nil:
201201
return false
202202
case lsc == nil:
203+
l.logger.Debugf("Current is nil")
203204
return true
204205
case !util.DeepEqual(lsc.Port, lsd.Port):
206+
l.logger.Debugf("Port needs to be changed (%v != %v)", log.Prettify(lsc.Port), log.Prettify(lsd.Port))
205207
return true
206208
case !util.DeepEqual(lsc.Protocol, lsd.Protocol):
209+
l.logger.Debugf("Protocol needs to be changed (%v != %v)", log.Prettify(lsc.Protocol), log.Prettify(lsd.Protocol))
207210
return true
208211
case !util.DeepEqual(lsc.Certificates, lsd.Certificates):
212+
l.logger.Debugf("Certificates needs to be changed (%v != %v)", log.Prettify(lsc.Certificates), log.Prettify(lsd.Certificates))
209213
return true
210214
case !util.DeepEqual(lsc.DefaultActions, lsd.DefaultActions):
215+
l.logger.Debugf("DefaultActions needs to be changed (%v != %v)", log.Prettify(lsc.DefaultActions), log.Prettify(lsd.DefaultActions))
211216
return true
212217
case !util.DeepEqual(lsc.SslPolicy, lsd.SslPolicy):
218+
l.logger.Debugf("SslPolicy needs to be changed (%v != %v)", log.Prettify(lsc.SslPolicy), log.Prettify(lsd.SslPolicy))
213219
return true
214220
}
215221
return false

pkg/alb/rs/rule.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,7 @@ func (r *Rule) Reconcile(rOpts *ReconcileOptions) error {
103103
log.Prettify(r.rs.current.Conditions))
104104

105105
case *r.rs.desired.IsDefault: // rule is default (attached to listener), do nothing
106-
r.logger.Debugf("Found desired rule that is a default and is already created with its respective listener. Rule: %s",
107-
log.Prettify(r.rs.desired))
106+
// r.logger.Debugf("Found desired rule that is a default and is already created with its respective listener. Rule: %s", log.Prettify(r.rs.desired))
108107
r.rs.current = r.rs.desired
109108

110109
case r.rs.current == nil: // rule doesn't exist and should be created

pkg/albingress/albingress.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ func (a *ALBIngress) Hostnames() ([]api.LoadBalancerIngress, error) {
225225
return nil, fmt.Errorf("No ALB hostnames for ingress")
226226
}
227227

228-
a.logger.Debugf("Ingress library requested hostname list and we returned %s", *a.loadBalancer.Hostname())
228+
// a.logger.Debugf("Ingress library requested hostname list and we returned %s", *a.loadBalancer.Hostname())
229229
return hostnames, nil
230230
}
231231

0 commit comments

Comments
 (0)