Skip to content

add validating webhook for ingress_class_params #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

M00nF1sh
Copy link
Collaborator

This PR adds additional checks in Ingress's validationWebhook to check IngressClass configurations.

  1. If IngressClass is not found, the validation webhook will fail
  2. If IngressClass is ALB and refers a unknown or non-exists parameters resource, the validation webhook will fail
  3. If IngressClass is ALB and refers a IngressClassParams with namespace selector and didn't match Ingress's namespace, the validation webhook will fail

See PR-1849 for overall design.

Test done:

  1. UTs
  2. Tests for various cases in UT:
    • admission webhook "vingress.elbv2.k8s.aws" denied the request: namespaceSelector of IngressClassParams my-class-params mismatch
    • admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClassParams.elbv2.k8s.aws "my-class-params" not found

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@k8s-ci-robot k8s-ci-robot requested a review from kishorj March 22, 2021 20:25
@kishorj
Copy link
Collaborator

kishorj commented Mar 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit e8eecf8 into kubernetes-sigs:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants