Skip to content

Update Installation manifests (CRD/Webhook/Controller) #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2021

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented May 11, 2021

The PR contains below changes:

  1. Updated CRD from apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1
  2. Updated Webhook from admissionregistration.k8s.io/v1beta1 to admissionregistration.k8s.io/v1.
    Note: admissionReviewVersions is kept as v1beta1, we'll upgrade this once we upgraded controller-runtime in future version.
  3. Added Controller Pod to have system-cluster-critical priority class.
  4. Updated controller-gen to be version 0.5.0
  5. Updated TargetGroupBindings CRD to not belong to "all" category.
  6. Updated IngressClassParams CRD to have print-columns.

Test done:

  • Tested with EKS v1.16 & v1.1.8 & v1.1.9:
    1. Apply old CRD & then apply new CRD, works fine.
    2. Apply new CRD directly, works fine.
  • Tested the print-columns of IngressClassParams works in case with specified fields vs non-specified fields.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2021
@k8s-ci-robot k8s-ci-robot requested a review from kishorj May 11, 2021 22:47
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #2000 (6223bc8) into main (8b52408) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2000   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files         130      130           
  Lines        6998     6998           
=======================================
  Hits         3417     3417           
  Misses       3303     3303           
  Partials      278      278           
Impacted Files Coverage Δ
webhooks/elbv2/targetgroupbinding_mutator.go 70.58% <ø> (ø)
webhooks/elbv2/targetgroupbinding_validator.go 87.17% <ø> (ø)
webhooks/networking/ingress_validator.go 56.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b52408...6223bc8. Read the comment docs.

@kishorj
Copy link
Collaborator

kishorj commented May 11, 2021

Fixes #1780

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kishorj
Copy link
Collaborator

kishorj commented May 11, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
@M00nF1sh M00nF1sh changed the title update TGB crd & IngressClassParams crd Update Installation manifests May 11, 2021
@M00nF1sh M00nF1sh changed the title Update Installation manifests Update Installation manifests (CRD/Webhook/Controller) May 11, 2021
@kishorj
Copy link
Collaborator

kishorj commented May 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4cb7510 into kubernetes-sigs:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants