Added feature gate to restrict to only ingress resources

[thejasn]

Signed-off-by: thejasn [email protected]

Issue

#2543

Description

Added a feature gate EnableServiceController which controls when the service reconciler is set up.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: thejasn / name: Thejas N (a67926a984d4185fca7ef20deffee2e9c7d3eb4c)

[k8s-ci-robot]

Welcome @thejasn!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @thejasn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thejasn]

Hey @kishorj, Can you PTAL and add the required labels?

[kishorj]

Thanks for the contribution. We are moving away to the feature gates instead of adding individual flags,

aws-load-balancer-controller/pkg/config/feature_gates.go

Line 19 in b5c8905

type FeatureGates interface {

We can use the EnableServiceController or a similar feature gate for this.

[thejasn]

Thanks for the contribution. We are moving away to the feature gates instead of adding individual flags,

aws-load-balancer-controller/pkg/config/feature_gates.go

Line 19 in b5c8905

type FeatureGates interface {

We can use the EnableServiceController or a similar feature gate for this.

Hey @kishorj, I've made the necessary changes. Let me know anything else is needed.

[kishorj]

/ok-to-test

[codecov-commenter]

Codecov Report

Merging #2579 (f0e348e) into main (88b6bdc) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2579      +/-   ##
==========================================
- Coverage   53.85%   53.83%   -0.02%     
==========================================
  Files         144      144              
  Lines        8165     8168       +3     
==========================================
  Hits         4397     4397              
- Misses       3451     3454       +3     
  Partials      317      317              

Impacted Files	Coverage Δ
pkg/config/feature_gates.go	0.00% <0.00%> (ø)
pkg/targetgroupbinding/resource_manager.go	15.17% <0.00%> (-0.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b6bdc...f0e348e. Read the comment docs.

[thejasn]

Hey @kishorj, do let me know what else is needed to get this merged. Thanks

[thejasn]

Hey @kishorj, checking in with you if anything else is needed from my side in order to proceed.

[kishorj]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kishorj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment