-
Notifications
You must be signed in to change notification settings - Fork 1.5k
upgrade controller-runtime to v0.9.7 #2833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @jdn5126! |
Hi @jdn5126. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jdn5126, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportBase: 54.05% // Head: 54.05% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
=======================================
Coverage 54.05% 54.05%
=======================================
Files 144 144
Lines 8278 8278
=======================================
Hits 4475 4475
Misses 3479 3479
Partials 324 324 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/lgtm |
* upgrade controller-runtime to v0.9.7 * go mod tidy
Issue
#2823
Description
This PR upgrades the
controller-runtime
module from v0.9.2 to v0.9.7 in order to fix the above issue. Upgrade was performed usinggo get sigs.k8s.io/[email protected]
with go1.18.3. Other module updates were due tocontroller-runtime
update in order to passmake test
.go mod tidy
was run after updatingcontroller-runtime
.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯