-
Notifications
You must be signed in to change notification settings - Fork 1.5k
maintain helm chart test.yaml file #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: BobDu <[email protected]>
|
Welcome @BobDu! |
Hi @BobDu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fawadkhaliq Can you have some time to see it? |
@BobDu - I'm no longer a maintainer of this project. @M00nF1sh, @kishorj should be able to help. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BobDu, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: BobDu <[email protected]> Signed-off-by: BobDu <[email protected]>
Signed-off-by: BobDu [email protected]
Issue
Description
test.yaml
in helm chart release package is a incomprehensible and unused file.Add
test.yaml
in.helmignore
.And best effort to keep it in sync with
values.yaml
.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯