Skip to content

Fix readinessProbe timeoutSeconds #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2018
Merged

Fix readinessProbe timeoutSeconds #460

merged 1 commit into from
Jul 16, 2018

Conversation

stevenpall
Copy link

As per https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#probe-v1-core, the readinessProbe timeout parameter should be timeoutSeconds instead of timeout.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2018
@k8s-ci-robot k8s-ci-robot requested a review from bigkraig July 16, 2018 22:03
@bigkraig bigkraig merged commit 12f764b into kubernetes-sigs:master Jul 16, 2018
@bigkraig
Copy link

nice catch!

bigkraig added a commit that referenced this pull request Oct 1, 2018
@bigkraig
Merge pull request #460 from twitsprout/master
cb67384 
Fix readinessProbe timeoutSeconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkraig bigkraig Awaiting requested review from bigkraig

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenpall @bigkraig @k8s-ci-robot