Close the channel earlier

wallrj · wallrj · commit 035949871343 · 2022-02-03T17:08:59.000Z
Signed-off-by: Richard Wall &lt;richard.wall@jetstack.io&gt;
diff --git a/pkg/cache/internal/informers_map.go b/pkg/cache/internal/informers_map.go
@@ -434,12 +434,12 @@ func (w *gvkFixupWatcher) run() {
 		w.ch <- e
 	}
 	w.wg.Done()
+	close(w.ch)
 }
 
 func (w *gvkFixupWatcher) Stop() {
 	w.watcher.Stop()
 	w.wg.Wait()
-	close(w.ch)
 }
 
 func (w *gvkFixupWatcher) ResultChan() <-chan watch.Event {

Original file line number	Diff line number	Diff line change
`@@ -434,12 +434,12 @@ func (w *gvkFixupWatcher) run() {`
`434`	`434`	`w.ch <- e`
`435`	`435`	`}`
`436`	`436`	`w.wg.Done()`
	`437`	`+ close(w.ch)`
`437`	`438`	`}`
`438`	`439`
`439`	`440`	`func (w *gvkFixupWatcher) Stop() {`
`440`	`441`	`w.watcher.Stop()`
`441`	`442`	`w.wg.Wait()`
`442`		`- close(w.ch)`
`443`	`443`	`}`
`444`	`444`
`445`	`445`	`func (w *gvkFixupWatcher) ResultChan() <-chan watch.Event {`