🐛 fix a bug in multinamespaced cache implementation

varshaprasad96 · alebedev87 · commit 03d09f6331a7 · 2023-04-24T16:55:29.000+02:00
This commit fixes a bug that was brought in long ago in #1520. When the object's scope is not deterministic from the RESTMapper it should return an error instead of ignoring it. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
diff --git a/pkg/cache/multi_namespace_cache.go b/pkg/cache/multi_namespace_cache.go
@@ -185,7 +185,7 @@ func (c *multiNamespaceCache) WaitForCacheSync(ctx context.Context) bool {
 func (c *multiNamespaceCache) IndexField(ctx context.Context, obj client.Object, field string, extractValue client.IndexerFunc) error {
 	isNamespaced, err := objectutil.IsAPINamespaced(obj, c.Scheme, c.RESTMapper)
 	if err != nil {
-		return nil //nolint:nilerr
+		return err
 	}
 
 	if !isNamespaced {

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ func (c *multiNamespaceCache) WaitForCacheSync(ctx context.Context) bool {`
`185`	`185`	`func (c *multiNamespaceCache) IndexField(ctx context.Context, obj client.Object, field string, extractValue client.IndexerFunc) error {`
`186`	`186`	`isNamespaced, err := objectutil.IsAPINamespaced(obj, c.Scheme, c.RESTMapper)`
`187`	`187`	`if err != nil {`
`188`		`- return nil //nolint:nilerr`
	`188`	`+ return err`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`if !isNamespaced {`