Skip to content

Commit 08763f8

Browse files
committed
Address droot comments
1 parent c205dab commit 08763f8

File tree

1 file changed

+31
-9
lines changed

1 file changed

+31
-9
lines changed

pkg/cache/cache_test.go

Lines changed: 31 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,20 @@ var _ = Describe("Informer Cache", func() {
191191

192192
Describe("as an Informer", func() {
193193
It("should be able to get informer for the object", func(done Done) {
194-
By("getting an shared index informer for a pod")
194+
By("getting a shared index informer for a pod")
195195
pod := &kcorev1.Pod{
196-
ObjectMeta: kmetav1.ObjectMeta{Name: "informer-obj", Namespace: "default"},
197-
Spec: kcorev1.PodSpec{Containers: []kcorev1.Container{{Name: "nginx", Image: "nginx"}}},
196+
ObjectMeta: kmetav1.ObjectMeta{
197+
Name: "informer-obj",
198+
Namespace: "default",
199+
},
200+
Spec: kcorev1.PodSpec{
201+
Containers: []kcorev1.Container{
202+
{
203+
Name: "nginx",
204+
Image: "nginx",
205+
},
206+
},
207+
},
198208
}
199209
sii, err := informerCache.GetInformer(pod)
200210
Expect(err).NotTo(HaveOccurred())
@@ -203,9 +213,10 @@ var _ = Describe("Informer Cache", func() {
203213

204214
By("adding an event handler listening for object creation which sends the object to a channel")
205215
out := make(chan interface{})
206-
sii.AddEventHandler(kcache.ResourceEventHandlerFuncs{AddFunc: func(obj interface{}) {
216+
addFunc := func(obj interface{}) {
207217
out <- obj
208-
}})
218+
}
219+
sii.AddEventHandler(kcache.ResourceEventHandlerFuncs{AddFunc: addFunc})
209220

210221
By("adding an object")
211222
cl, err := client.New(cfg, client.Options{})
@@ -227,16 +238,27 @@ var _ = Describe("Informer Cache", func() {
227238

228239
By("adding an event handler listening for object creation which sends the object to a channel")
229240
out := make(chan interface{})
230-
sii.AddEventHandler(kcache.ResourceEventHandlerFuncs{AddFunc: func(obj interface{}) {
241+
addFunc := func(obj interface{}) {
231242
out <- obj
232-
}})
243+
}
244+
sii.AddEventHandler(kcache.ResourceEventHandlerFuncs{AddFunc: addFunc})
233245

234246
By("adding an object")
235247
cl, err := client.New(cfg, client.Options{})
236248
Expect(err).NotTo(HaveOccurred())
237249
pod := &kcorev1.Pod{
238-
ObjectMeta: kmetav1.ObjectMeta{Name: "informer-gvk", Namespace: "default"},
239-
Spec: kcorev1.PodSpec{Containers: []kcorev1.Container{{Name: "nginx", Image: "nginx"}}},
250+
ObjectMeta: kmetav1.ObjectMeta{
251+
Name: "informer-gvk",
252+
Namespace: "default",
253+
},
254+
Spec: kcorev1.PodSpec{
255+
Containers: []kcorev1.Container{
256+
{
257+
Name: "nginx",
258+
Image: "nginx",
259+
},
260+
},
261+
},
240262
}
241263
Expect(cl.Create(context.TODO(), pod)).To(Succeed())
242264

0 commit comments

Comments
 (0)