Lint

Author: JoelSpeed

pkg/internal/controller/metrics/metrics.go

@@ -22,16 +22,22 @@ import (
 )
 
 var (
+	// QueueLength is a prometheus metric which counts the current reconcile
+	// queue length per controller
 	QueueLength = prometheus.NewGaugeVec(prometheus.GaugeOpts{
 		Name: "controller_runtime_reconcile_queue_length",
 		Help: "Length of reconcile queue per controller",
 	}, []string{"controller"})
 
+	// ReconcileErrors is a prometheus counter metrics which holds the total
+	// number of errors from the Reconciler
 	ReconcileErrors = prometheus.NewCounterVec(prometheus.CounterOpts{
 		Name: "controller_runtime_reconcile_errors_total",
 		Help: "Total number of reconcile errors per controller",
 	}, []string{"controller"})
 
+	// ReconcileTime is a prometheus metric which keeps track of the duration
+	// of reconciles
 	ReconcileTime = prometheus.NewHistogramVec(prometheus.HistogramOpts{
 		Name: "controller_runtime_reconcile_time_second",
 		Help: "Length of time per reconcile per controller",

pkg/manager/internal.go

@@ -185,7 +185,9 @@ func (cm *controllerManager) serveMetrics(stop <-chan struct{}) {
 	// Shutdown the server when stop is closed
 	select {
 	case <-stop:
-		server.Shutdown(context.Background())
+		if err := server.Shutdown(context.Background()); err != nil {
+			cm.errChan <- err
+		}
 	}
 }
 

pkg/metrics/doc.go

@@ -17,5 +17,4 @@ limitations under the License.
 /*
 Package metrics contains controller related metrics utilities
 */
-
 package metrics