🌱 simplify syntax

Signed-off-by: Alexandre Mahdhaoui <[email protected]>

Author: alexandremahdhaoui

hack/tools/cmd/gomodcheck/main.go

@@ -85,24 +85,28 @@ func main() {
 		}
 
 		if versionToRef, ok := upstreamModules[mod]; ok {
-			upstreams := make([]upstream, 0)
+			outOfSyncUpstream := make([]upstream, 0)
 
 			for upstreamVersion, upstreamRef := range versionToRef {
-				if version != upstreamVersion {
-					upstreams = append(upstreams, upstream{
-						Ref:     upstreamRef,
-						Version: upstreamVersion,
-					})
+				if version == upstreamVersion { // pass if version in sync.
+					continue
 				}
-			}
 
-			if len(upstreams) > 0 {
-				oosMods = append(oosMods, oosMod{
-					Name:      mod,
-					Version:   version,
-					Upstreams: upstreams,
+				outOfSyncUpstream = append(outOfSyncUpstream, upstream{
+					Ref:     upstreamRef,
+					Version: upstreamVersion,
 				})
 			}
+
+			if len(outOfSyncUpstream) == 0 { // pass if no out of sync upstreams.
+				continue
+			}
+
+			oosMods = append(oosMods, oosMod{
+				Name:      mod,
+				Version:   version,
+				Upstreams: outOfSyncUpstream,
+			})
 		}
 	}