fix: bad loop logic

alexeldeib · alexeldeib · commit 0ba00d634664 · 2019-08-15T06:37:24.000-07:00
diff --git a/pkg/controller/controllerutil/controllerutil.go b/pkg/controller/controllerutil/controllerutil.go
@@ -198,6 +198,7 @@ func RemoveFinalizer(o metav1.Object, finalizer string) {
 	for i, e := range f {
 		if e == finalizer {
 			f = append(f[:i], f[i+1:]...)
+			return
 		}
 	}
 	o.SetFinalizers(f)

Original file line number	Diff line number	Diff line change
`@@ -198,6 +198,7 @@ func RemoveFinalizer(o metav1.Object, finalizer string) {`
`198`	`198`	`for i, e := range f {`
`199`	`199`	`if e == finalizer {`
`200`	`200`	`f = append(f[:i], f[i+1:]...)`
	`201`	`+ return`
`201`	`202`	`}`
`202`	`203`	`}`
`203`	`204`	`o.SetFinalizers(f)`