Change MergeFrom to use strategic merge patch

Strategic merge patch is what most things in kubernetes use, and
probably closer to what users expect if they can't use server-side
apply.

Author: DirectXMan12

pkg/client/client_test.go

@@ -2228,7 +2228,7 @@ var _ = Describe("Patch", func() {
 			}
 		})
 
-		It("creates a merge patch with the modifications applied during the mutation", func() {
+		It("creates a strategic merge patch with the modifications applied during the mutation", func() {
 			const (
 				annotationKey   = "test"
 				annotationValue = "foo"
@@ -2238,7 +2238,7 @@ var _ = Describe("Patch", func() {
 			patch := client.MergeFrom(cm.DeepCopy())
 
 			By("returning a patch with type MergePatch")
-			Expect(patch.Type()).To(Equal(types.MergePatchType))
+			Expect(patch.Type()).To(Equal(types.StrategicMergePatchType))
 
 			By("retrieving modifying the config map")
 			metav1.SetMetaDataAnnotation(&cm.ObjectMeta, annotationKey, annotationValue)

pkg/client/patch.go

@@ -17,10 +17,10 @@ limitations under the License.
 package client
 
 import (
-	jsonpatch "github.com/evanphx/json-patch"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/apimachinery/pkg/util/json"
+	"k8s.io/apimachinery/pkg/util/strategicpatch"
 )
 
 type patch struct {
@@ -49,7 +49,7 @@ type mergeFromPatch struct {
 
 // Type implements patch.
 func (s *mergeFromPatch) Type() types.PatchType {
-	return types.MergePatchType
+	return types.StrategicMergePatchType
 }
 
 // Data implements Patch.
@@ -64,10 +64,11 @@ func (s *mergeFromPatch) Data(obj runtime.Object) ([]byte, error) {
 		return nil, err
 	}
 
-	return jsonpatch.CreateMergePatch(originalJSON, modifiedJSON)
+	return strategicpatch.CreateTwoWayMergePatch(originalJSON, modifiedJSON, obj)
 }
 
-// MergeFrom creates a Patch that patches using the merge-patch strategy with the given object as base.
+// MergeFrom creates a Patch that patches using the strategic
+// merge-patch strategy with the given object as base.
 func MergeFrom(obj runtime.Object) Patch {
 	return &mergeFromPatch{obj}
 }