Skip to content

Commit 15b5243

Browse files
authored
Merge pull request #683 from mengqiy/fakeclient
👻add apiversion handling to fake client
2 parents 2f2e975 + cd4d24b commit 15b5243

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

pkg/client/fake/client.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ func (c *fakeClient) Get(ctx context.Context, key client.ObjectKey, obj runtime.
116116
return err
117117
}
118118
ta.SetKind(gvk.Kind)
119+
ta.SetAPIVersion(gvk.GroupVersion().String())
119120

120121
j, err := json.Marshal(o)
121122
if err != nil {
@@ -154,6 +155,7 @@ func (c *fakeClient) List(ctx context.Context, obj runtime.Object, opts ...clien
154155
return err
155156
}
156157
ta.SetKind(OriginalKind)
158+
ta.SetAPIVersion(gvk.GroupVersion().String())
157159

158160
j, err := json.Marshal(o)
159161
if err != nil {
@@ -317,6 +319,7 @@ func (c *fakeClient) Patch(ctx context.Context, obj runtime.Object, patch client
317319
return err
318320
}
319321
ta.SetKind(gvk.Kind)
322+
ta.SetAPIVersion(gvk.GroupVersion().String())
320323

321324
j, err := json.Marshal(o)
322325
if err != nil {

pkg/client/fake/client_test.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ var _ = Describe("Fake client", func() {
4141
BeforeEach(func() {
4242
dep = &appsv1.Deployment{
4343
TypeMeta: metav1.TypeMeta{
44-
Kind: "Deployment",
44+
APIVersion: "apps/v1",
45+
Kind: "Deployment",
4546
},
4647
ObjectMeta: metav1.ObjectMeta{
4748
Name: "test-deployment",
@@ -50,7 +51,8 @@ var _ = Describe("Fake client", func() {
5051
}
5152
dep2 = &appsv1.Deployment{
5253
TypeMeta: metav1.TypeMeta{
53-
Kind: "Deployment",
54+
APIVersion: "apps/v1",
55+
Kind: "Deployment",
5456
},
5557
ObjectMeta: metav1.ObjectMeta{
5658
Name: "test-deployment-2",
@@ -62,7 +64,8 @@ var _ = Describe("Fake client", func() {
6264
}
6365
cm = &corev1.ConfigMap{
6466
TypeMeta: metav1.TypeMeta{
65-
Kind: "ConfigMap",
67+
APIVersion: "v1",
68+
Kind: "ConfigMap",
6669
},
6770
ObjectMeta: metav1.ObjectMeta{
6871
Name: "test-cm",
@@ -135,7 +138,8 @@ var _ = Describe("Fake client", func() {
135138
By("Creating a new configmap")
136139
newcm := &corev1.ConfigMap{
137140
TypeMeta: metav1.TypeMeta{
138-
Kind: "ConfigMap",
141+
APIVersion: "v1",
142+
Kind: "ConfigMap",
139143
},
140144
ObjectMeta: metav1.ObjectMeta{
141145
Name: "new-test-cm",
@@ -161,7 +165,8 @@ var _ = Describe("Fake client", func() {
161165
By("Updating a new configmap")
162166
newcm := &corev1.ConfigMap{
163167
TypeMeta: metav1.TypeMeta{
164-
Kind: "ConfigMap",
168+
APIVersion: "v1",
169+
Kind: "ConfigMap",
165170
},
166171
ObjectMeta: metav1.ObjectMeta{
167172
Name: "test-cm",

0 commit comments

Comments
 (0)