Skip to content

Commit 1b9b748

Browse files
committed
address comments
1 parent a5c5dd9 commit 1b9b748

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

test/e2e/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func initConfig(testSuffix string) *config {
4848
kind: "Foo" + testSuffix,
4949
installName: installName,
5050
namespace: testNamespace,
51-
controllerImageName: "gcr.io/kubeships/controller-manager:" + testSuffix,
51+
controllerImageName: "e2e-test/controller-manager:" + testSuffix,
5252
workDir: filepath.Join(framework.TestContext.ProjectDir, "e2e-"+testSuffix),
5353
}
5454
}

test/e2e/e2e.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import (
2929
"github.com/kubernetes-sigs/kubebuilder/test/e2e/framework"
3030
"github.com/kubernetes-sigs/kubebuilder/test/e2e/framework/ginkgowrapper"
3131
e2einternal "github.com/kubernetes-sigs/kubebuilder/test/internal/e2e"
32-
3332
. "github.com/onsi/ginkgo"
3433
. "github.com/onsi/gomega"
3534

test/internal/e2e/kubebuildertest.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ func (kt *KubebuilderTest) runCommand(cmd *exec.Cmd) ([]byte, error) {
191191
command := strings.Join(cmd.Args, " ")
192192
output, err := cmd.Output()
193193
if err != nil {
194-
return output, fmt.Errorf("%s failed with error: %v", command, err)
194+
return output, fmt.Errorf("%s failed with error: %s", command, string(output))
195195
}
196196
log.Printf("%s finished successfully", command)
197197
return output, nil

0 commit comments

Comments
 (0)