fix gocyclo

Author: lichuqiang

pkg/manager/manager.go

@@ -109,30 +109,21 @@ func New(config *rest.Config, options Options) (Manager, error) {
 		cm.scheme = scheme.Scheme
 	}
 
-	// Create a new RESTMapper for mapping GroupVersionKinds to Resources
-	if options.MapperProvider == nil {
-		options.MapperProvider = apiutil.NewDiscoveryRESTMapper
-	}
+	// Set default values for options fields
+	options = setOptionsDefaults(options)
+
 	mapper, err := options.MapperProvider(cm.config)
 	if err != nil {
 		log.Error(err, "Failed to get API Group-Resources")
 		return nil, err
 	}
 
-	// Allow newClient to be mocked
-	if options.newClient == nil {
-		options.newClient = client.New
-	}
 	// Create the Client for Write operations.
 	writeObj, err := options.newClient(cm.config, client.Options{Scheme: cm.scheme, Mapper: mapper})
 	if err != nil {
 		return nil, err
 	}
 
-	// TODO(directxman12): Figure out how to allow users to request a client without requesting a watch
-	if options.newCache == nil {
-		options.newCache = cache.New
-	}
 	cm.cache, err = options.newCache(cm.config, cache.Options{Scheme: cm.scheme, Mapper: mapper})
 	if err != nil {
 		return nil, err
@@ -141,9 +132,6 @@ func New(config *rest.Config, options Options) (Manager, error) {
 	cm.fieldIndexes = cm.cache
 	cm.client = client.DelegatingClient{Reader: cm.cache, Writer: writeObj}
 
-	if options.newRecorderProvider == nil {
-		options.newRecorderProvider = internalrecorder.NewProvider
-	}
 	// Create the recorder provider to inject event recorders for the components.
 	cm.recorderProvider, err = options.newRecorderProvider(cm.config, cm.scheme)
 	if err != nil {
@@ -152,3 +140,28 @@ func New(config *rest.Config, options Options) (Manager, error) {
 
 	return cm, nil
 }
+
+// setOptionsDefaults set default values for Options fields.
+func setOptionsDefaults(options Options) Options {
+	if options.MapperProvider == nil {
+		options.MapperProvider = apiutil.NewDiscoveryRESTMapper
+	}
+
+	// Allow newClient to be mocked.
+	if options.newClient == nil {
+		options.newClient = client.New
+	}
+
+	// Allow newCache to be mocked.
+	// TODO(directxman12): Figure out how to allow users to request a client without requesting a watch.
+	if options.newCache == nil {
+		options.newCache = cache.New
+	}
+
+	// Allow newRecorderProvider to be mocked.
+	if options.newRecorderProvider == nil {
+		options.newRecorderProvider = internalrecorder.NewProvider
+	}
+
+	return options
+}