Skip to content

Commit 29b471a

Browse files
committed
Don't use pointer for sync.Mutex
1 parent cf499c8 commit 29b471a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/log/deleg.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import (
2727
type loggerPromise struct {
2828
logger *DelegatingLogger
2929
childPromises []*loggerPromise
30-
promisesLock *sync.Mutex
30+
promisesLock sync.Mutex
3131

3232
name *string
3333
tags []interface{}
@@ -38,7 +38,7 @@ func (p *loggerPromise) WithName(l *DelegatingLogger, name string) *loggerPromis
3838
res := &loggerPromise{
3939
logger: l,
4040
name: &name,
41-
promisesLock: &sync.Mutex{},
41+
promisesLock: sync.Mutex{},
4242
}
4343

4444
p.promisesLock.Lock()
@@ -52,7 +52,7 @@ func (p *loggerPromise) WithValues(l *DelegatingLogger, tags ...interface{}) *lo
5252
res := &loggerPromise{
5353
logger: l,
5454
tags: tags,
55-
promisesLock: &sync.Mutex{},
55+
promisesLock: sync.Mutex{},
5656
}
5757

5858
p.promisesLock.Lock()
@@ -130,7 +130,7 @@ func (l *DelegatingLogger) Fulfill(actual logr.Logger) {
130130
func NewDelegatingLogger(initial logr.Logger) *DelegatingLogger {
131131
l := &DelegatingLogger{
132132
Logger: initial,
133-
promise: &loggerPromise{promisesLock: &sync.Mutex{}},
133+
promise: &loggerPromise{promisesLock: sync.Mutex{}},
134134
}
135135
l.promise.logger = l
136136
return l

0 commit comments

Comments
 (0)