Dealing with nil Type

Shawn Hurley · Shawn Hurley · commit 2b3238dd62d8 · 2018-10-10T16:12:28.000-04:00
diff --git a/pkg/source/source.go b/pkg/source/source.go
@@ -96,7 +96,10 @@ func (ks *Kind) Start(handler handler.EventHandler, queue workqueue.RateLimiting
 }
 
 func (ks *Kind) String() string {
-	return fmt.Sprintf("kind source: %v", ks.Type.GetObjectKind().GroupVersionKind().String())
+	if ks.Type != nil && ks.Type.GetObjectKind() != nil {
+		return fmt.Sprintf("kind source: %v", ks.Type.GetObjectKind().GroupVersionKind().String())
+	}
+	return fmt.Sprintf("kind source: unknown GVK")
 }
 
 var _ inject.Cache = &Kind{}

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,10 @@ func (ks *Kind) Start(handler handler.EventHandler, queue workqueue.RateLimiting`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`func (ks *Kind) String() string {`
`99`		`- return fmt.Sprintf("kind source: %v", ks.Type.GetObjectKind().GroupVersionKind().String())`
	`99`	`+ if ks.Type != nil && ks.Type.GetObjectKind() != nil {`
	`100`	`+ return fmt.Sprintf("kind source: %v", ks.Type.GetObjectKind().GroupVersionKind().String())`
	`101`	`+ }`
	`102`	`+ return fmt.Sprintf("kind source: unknown GVK")`
`100`	`103`	`}`
`101`	`104`
`102`	`105`	`var _ inject.Cache = &Kind{}`