You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: designs/conditional-controllers.md
+12-15Lines changed: 12 additions & 15 deletions
Original file line number
Diff line number
Diff line change
@@ -183,29 +183,29 @@ breaks the clean design of the cache.
183
183
184
184
### Stoppable Informers and EventHandler removal natively in client-go
185
185
186
+
*This proposal was discussed with sig-api-machinery on 11/5 and has been
187
+
tentatively accepted. See the [design
188
+
doc](https://docs.google.com/document/d/17QrTaxfIEUNOEAt61Za3Mu0M76x-iEkcmR51q0a5lis/edit) and [WIP implementation](https://github.com/kevindelgado/kubernetes/pull/1) for more detail.*
189
+
186
190
A few changes to the underlying SharedInformer interface in client-go could save
187
191
us from a lot of work in controller-runtime.
188
192
189
193
One is to add a second `Run` method on the `SharedInformer` interface such as
190
194
```
191
195
// RunWithStopOptions runs the informer and provides options to be checked that
192
196
// would indicate under what conditions the informer should stop
(where `id`` is a to be determined identifer of the specific handler to be
229
-
removed).
230
228
231
229
This would remove the need to track it ourselves in controller-runtime.
232
230
233
-
TODO: Bring this design up (potentially with a proof-of-concept branch) at an
234
-
upcoming sig-api-machinery meeting to begin getting feedback and see whether it
235
-
is feasible to land the changes in client-go.
236
-
237
231
## Open Questions
238
232
239
233
### Multiple Restarts
@@ -298,4 +292,7 @@ controller-runtime
298
292
* 10/8/2020: Discuss idea in community meeting
299
293
* 10/19/2020: Proposal updated to add EventHandler count tracking and client-go
300
294
based alternative.
295
+
* 11/4/2020: Propopsal to add RunWithStopOptions, RemoveEventHandler, and
296
+
EventHandlerCount discussed at sig-api-machinery meeting and was tentatively
297
+
accepted. See the [design doc](https://docs.google.com/document/d/17QrTaxfIEUNOEAt61Za3Mu0M76x-iEkcmR51q0a5lis/edit) and [WIP implementation](https://github.com/kevindelgado/kubernetes/pull/1) for more detail.
0 commit comments