Error when ReconcileFn changes object name/namespace

Author: calind

pkg/controller/controllerutil/controllerutil.go

@@ -135,14 +135,22 @@ func CreateOrUpdate(ctx context.Context, c client.Client, obj runtime.Object, r
 
 	// reconcile the existing object
 	newobj := existing.DeepCopyObject()
-	if e := r(newobj); e != nil {
-		return OperationNoop, e
-	}
-	// as promised, CreateOrUpdate creates or updates object with the same name and namespace
 	newmo := newobj.(v1.Object)
 	newmo.SetName(mo.GetName())
 	newmo.SetNamespace(mo.GetNamespace())
 
+	if e := r(newobj); e != nil {
+		return OperationNoop, e
+	}
+
+	if newmo.GetName() != mo.GetName() {
+		return OperationNoop, fmt.Errorf("ReconcileFn cannot mutate objects name")
+	}
+
+	if newmo.GetNamespace() != mo.GetNamespace() {
+		return OperationNoop, fmt.Errorf("ReconcileFn cannot mutate objects namespace")
+	}
+
 	if errors.IsNotFound(err) {
 		err = c.Create(ctx, newobj)
 		op = OperationCreate
@@ -163,5 +171,4 @@ func CreateOrUpdate(ctx context.Context, c client.Client, obj runtime.Object, r
 }
 
 // ReconcileFn is a function which mutates the existing object into it's desired state.
-// If there is no existing object, a zero value object is passed in.
 type ReconcileFn func(existing runtime.Object) error

pkg/controller/controllerutil/controllerutil_test.go

@@ -186,6 +186,36 @@ var _ = Describe("Controllerutil", func() {
 			By("returning no error")
 			Expect(err).NotTo(HaveOccurred())
 		})
+
+		It("errors when reconcile renames an object", func() {
+			op, err := controllerutil.CreateOrUpdate(context.TODO(), c, deploy, deploymentSpecr(deplSpec))
+
+			Expect(op).To(BeEquivalentTo(controllerutil.OperationCreate))
+			Expect(err).NotTo(HaveOccurred())
+
+			op, err = controllerutil.CreateOrUpdate(context.TODO(), c, deploy, deploymentRenamer)
+
+			By("returning OperationNoop")
+			Expect(op).To(BeEquivalentTo(controllerutil.OperationNoop))
+
+			By("returning error")
+			Expect(err).To(HaveOccurred())
+		})
+
+		It("errors when object namespace changes", func() {
+			op, err := controllerutil.CreateOrUpdate(context.TODO(), c, deploy, deploymentSpecr(deplSpec))
+
+			Expect(op).To(BeEquivalentTo(controllerutil.OperationCreate))
+			Expect(err).NotTo(HaveOccurred())
+
+			op, err = controllerutil.CreateOrUpdate(context.TODO(), c, deploy, deploymentNamespaceChanger)
+
+			By("returning OperationNoop")
+			Expect(op).To(BeEquivalentTo(controllerutil.OperationNoop))
+
+			By("returning error")
+			Expect(err).To(HaveOccurred())
+		})
 	})
 })
 
@@ -207,6 +237,18 @@ var deploymentIdentity controllerutil.ReconcileFn = func(obj runtime.Object) err
 	return nil
 }
 
+var deploymentRenamer controllerutil.ReconcileFn = func(obj runtime.Object) error {
+	deploy := obj.(*appsv1.Deployment)
+	deploy.Name = fmt.Sprintf("%s-1", deploy.Name)
+	return nil
+}
+
+var deploymentNamespaceChanger controllerutil.ReconcileFn = func(obj runtime.Object) error {
+	deploy := obj.(*appsv1.Deployment)
+	deploy.Namespace = fmt.Sprintf("%s-1", deploy.Namespace)
+	return nil
+}
+
 func deploymentScaler(replicas int32) controllerutil.ReconcileFn {
 	fn := func(obj runtime.Object) error {
 		deploy := obj.(*appsv1.Deployment)