chore: refine interface methods declration

Signed-off-by: STRRL <[email protected]>

Author: STRRL

pkg/webhook/admission/admissiontest/util.go

@@ -79,16 +79,16 @@ type FakeValidatorWarn struct {
 	WarningsToReturn []string
 }
 
-func (v *FakeValidatorWarn) ValidateCreate() (err error, warnings []string) {
-	return v.ErrorToReturn, v.WarningsToReturn
+func (v *FakeValidatorWarn) ValidateCreate() (warnings []string, err error) {
+	return v.WarningsToReturn, v.ErrorToReturn
 }
 
-func (v *FakeValidatorWarn) ValidateUpdate(old runtime.Object) (err error, warnings []string) {
-	return v.ErrorToReturn, v.WarningsToReturn
+func (v *FakeValidatorWarn) ValidateUpdate(old runtime.Object) (warnings []string, err error) {
+	return v.WarningsToReturn, v.ErrorToReturn
 }
 
-func (v *FakeValidatorWarn) ValidateDelete() (err error, warnings []string) {
-	return v.ErrorToReturn, v.WarningsToReturn
+func (v *FakeValidatorWarn) ValidateDelete() (warnings []string, err error) {
+	return v.WarningsToReturn, v.ErrorToReturn
 }
 
 func (v *FakeValidatorWarn) SetGroupVersionKind(kind schema.GroupVersionKind) {

pkg/webhook/admission/validator_warn.go

@@ -29,13 +29,16 @@ import (
 // ValidatorWarn works like Validator, but it allows to return warnings.
 type ValidatorWarn interface {
 	runtime.Object
-	ValidateCreate() (err error, warnings []string)
-	ValidateUpdate(old runtime.Object) (err error, warnings []string)
-	ValidateDelete() (err error, warnings []string)
+	ValidateCreate() (warnings []string, err error)
+	ValidateUpdate(old runtime.Object) (warnings []string, err error)
+	ValidateDelete() (warnings []string, err error)
 }
 
+// ValidatingWebhookWithWarningFor creates a new Webhook for validating the provided type with warning messages.
 func ValidatingWebhookWithWarningFor(validatorWarning ValidatorWarn) *Webhook {
-	return nil
+	return &Webhook{
+		Handler: &validatingWarnHandler{validatorWarn: validatorWarning},
+	}
 }
 
 var _ Handler = &validatingWarnHandler{}
@@ -68,7 +71,7 @@ func (h *validatingWarnHandler) Handle(ctx context.Context, req Request) Respons
 			return Errored(http.StatusBadRequest, err)
 		}
 
-		err, warnings := obj.ValidateCreate()
+		warnings, err := obj.ValidateCreate()
 		allWarnings = append(allWarnings, warnings...)
 		if err != nil {
 			var apiStatus apierrors.APIStatus
@@ -90,7 +93,7 @@ func (h *validatingWarnHandler) Handle(ctx context.Context, req Request) Respons
 		if err != nil {
 			return Errored(http.StatusBadRequest, err)
 		}
-		err, warnings := obj.ValidateUpdate(oldObj)
+		warnings, err := obj.ValidateUpdate(oldObj)
 		allWarnings = append(allWarnings, warnings...)
 		if err != nil {
 			var apiStatus apierrors.APIStatus
@@ -109,7 +112,7 @@ func (h *validatingWarnHandler) Handle(ctx context.Context, req Request) Respons
 			return Errored(http.StatusBadRequest, err)
 		}
 
-		err, warnings := obj.ValidateDelete()
+		warnings, err := obj.ValidateDelete()
 		allWarnings = append(allWarnings, warnings...)
 		if err != nil {
 			var apiStatus apierrors.APIStatus