Skip to content

Commit 33f1d80

Browse files
authored
Merge pull request #1259 from alvaroaleman/allow-with-list
⚠️ Fakeclient: Allow to pass ObjectLists to constructors
2 parents 3e4e60c + a8d801f commit 33f1d80

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/client/fake/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,14 @@ const (
5959

6060
// NewFakeClient creates a new fake client for testing.
6161
// You can choose to initialize it with a slice of runtime.Object.
62-
func NewFakeClient(initObjs ...client.Object) client.Client {
62+
func NewFakeClient(initObjs ...runtime.Object) client.Client {
6363
return NewFakeClientWithScheme(scheme.Scheme, initObjs...)
6464
}
6565

6666
// NewFakeClientWithScheme creates a new fake client with the given scheme
6767
// for testing.
6868
// You can choose to initialize it with a slice of runtime.Object.
69-
func NewFakeClientWithScheme(clientScheme *runtime.Scheme, initObjs ...client.Object) client.Client {
69+
func NewFakeClientWithScheme(clientScheme *runtime.Scheme, initObjs ...runtime.Object) client.Client {
7070
tracker := testing.NewObjectTracker(clientScheme, scheme.Codecs.UniversalDecoder())
7171
for _, obj := range initObjs {
7272
err := tracker.Add(obj)

pkg/client/fake/client_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ var _ = Describe("Fake client", func() {
541541
Expect(corev1.AddToScheme(scheme)).To(Succeed())
542542
Expect(appsv1.AddToScheme(scheme)).To(Succeed())
543543
Expect(coordinationv1.AddToScheme(scheme)).To(Succeed())
544-
cl = NewFakeClientWithScheme(scheme, dep, dep2, cm)
544+
cl = NewFakeClientWithScheme(scheme, &appsv1.DeploymentList{Items: []appsv1.Deployment{*dep, *dep2}}, cm)
545545
close(done)
546546
})
547547
AssertClientBehavior()

0 commit comments

Comments
 (0)