Removed newTimeEncoder(), returns error on invalid value

Author: bharathi-tenneti

pkg/log/zap/flags.go

@@ -106,23 +106,17 @@ func (ev *timeEncoderFlag) Type() string {
 }
 
 func (ev *timeEncoderFlag) Set(flagValue string) error {
-	ev.setFunc(newTimeEncoder(flagValue))
-	ev.value = flagValue
-	return nil
-}
-
-func newTimeEncoder(flagValue string) zapcore.TimeEncoder {
 	var encoder zapcore.TimeEncoder
 	val := strings.ToLower(flagValue)
 	switch val {
 	case "iso8601", "rfc3339", "rfc3339nano", "millis", "nanos", "epoch":
-		if err := encoder.UnmarshalText([]byte(val)); err != nil {
-			fmt.Printf("not able to unmarshal time encoder value \"%s\"", val)
-		}
+		encoder.UnmarshalText([]byte(val))
 	default:
-		fmt.Printf("invalid time encoder value \"%s\"", val)
+		return fmt.Errorf("invalid value for time encoder, \"%s\"", val)
 	}
-	return encoder
+	ev.setFunc(encoder)
+	ev.value = flagValue
+	return nil
 }
 
 func withTimeEncoding(te zapcore.TimeEncoder) encoderConfigFunc {