Skip to content

Commit 389b893

Browse files
author
interma
committed
use controller-runtime logging in controller
1 parent b13b973 commit 389b893

File tree

8 files changed

+24
-18
lines changed

8 files changed

+24
-18
lines changed

pkg/scaffold/controller/controller.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,12 @@ import (
120120
"sigs.k8s.io/controller-runtime/pkg/handler"
121121
"sigs.k8s.io/controller-runtime/pkg/manager"
122122
"sigs.k8s.io/controller-runtime/pkg/reconcile"
123+
logf "sigs.k8s.io/controller-runtime/pkg/runtime/log"
123124
"sigs.k8s.io/controller-runtime/pkg/source"
124125
{{ .Resource.Group}}{{ .Resource.Version }} "{{ .ResourcePackage }}/{{ .Resource.Group}}/{{ .Resource.Version }}"
126+
)
127+
128+
var log = logf.Log.WithName("controller")
125129
{{ else }} "context"
126130
127131
appsv1 "k8s.io/api/apps/v1"
@@ -133,8 +137,8 @@ import (
133137
"sigs.k8s.io/controller-runtime/pkg/reconcile"
134138
"sigs.k8s.io/controller-runtime/pkg/source"
135139
{{ .Resource.Group}}{{ .Resource.Version }} "{{ .ResourcePackage }}/{{ .Resource.Group}}/{{ .Resource.Version }}"
136-
{{ end -}}
137140
)
141+
{{ end -}}
138142
139143
/**
140144
* USER ACTION REQUIRED: This is a scaffold file intended for the user to modify with their own Controller
@@ -245,7 +249,7 @@ func (r *Reconcile{{ .Resource.Kind }}) Reconcile(request reconcile.Request) (re
245249
found := &appsv1.Deployment{}
246250
err = r.Get(context.TODO(), types.NamespacedName{Name: deploy.Name, Namespace: deploy.Namespace}, found)
247251
if err != nil && errors.IsNotFound(err) {
248-
log.Printf("Creating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
252+
log.Info("Creating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
249253
err = r.Create(context.TODO(), deploy)
250254
if err != nil {
251255
return reconcile.Result{}, err
@@ -258,7 +262,7 @@ func (r *Reconcile{{ .Resource.Kind }}) Reconcile(request reconcile.Request) (re
258262
// Update the found object and write the result back if there are any changes
259263
if !reflect.DeepEqual(deploy.Spec, found.Spec) {
260264
found.Spec = deploy.Spec
261-
log.Printf("Updating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
265+
log.Info("Updating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
262266
err = r.Update(context.TODO(), found)
263267
if err != nil {
264268
return reconcile.Result{}, err

pkg/scaffold/controller/controllersuitetest.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var controllerSuiteTestTemplate = `{{ .Boilerplate }}
4747
package {{ lower .Resource.Kind }}
4848
4949
import (
50-
"log"
50+
stdlog "log"
5151
"os"
5252
"path/filepath"
5353
"sync"
@@ -72,7 +72,7 @@ func TestMain(m *testing.M) {
7272
7373
var err error
7474
if cfg, err = t.Start(); err != nil {
75-
log.Fatal(err)
75+
stdlog.Fatal(err)
7676
}
7777
7878
code := m.Run()

test/project/pkg/controller/firstmate/firstmate_controller.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package firstmate
1818

1919
import (
2020
"context"
21-
"log"
2221
"reflect"
2322

2423
appsv1 "k8s.io/api/apps/v1"
@@ -33,10 +32,13 @@ import (
3332
"sigs.k8s.io/controller-runtime/pkg/handler"
3433
"sigs.k8s.io/controller-runtime/pkg/manager"
3534
"sigs.k8s.io/controller-runtime/pkg/reconcile"
35+
logf "sigs.k8s.io/controller-runtime/pkg/runtime/log"
3636
"sigs.k8s.io/controller-runtime/pkg/source"
3737
crewv1 "sigs.k8s.io/kubebuilder/test/project/pkg/apis/crew/v1"
3838
)
3939

40+
var log = logf.Log.WithName("controller")
41+
4042
/**
4143
* USER ACTION REQUIRED: This is a scaffold file intended for the user to modify with their own Controller
4244
* business logic. Delete these comments after modifying this file.*
@@ -143,7 +145,7 @@ func (r *ReconcileFirstMate) Reconcile(request reconcile.Request) (reconcile.Res
143145
found := &appsv1.Deployment{}
144146
err = r.Get(context.TODO(), types.NamespacedName{Name: deploy.Name, Namespace: deploy.Namespace}, found)
145147
if err != nil && errors.IsNotFound(err) {
146-
log.Printf("Creating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
148+
log.Info("Creating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
147149
err = r.Create(context.TODO(), deploy)
148150
if err != nil {
149151
return reconcile.Result{}, err
@@ -156,7 +158,7 @@ func (r *ReconcileFirstMate) Reconcile(request reconcile.Request) (reconcile.Res
156158
// Update the found object and write the result back if there are any changes
157159
if !reflect.DeepEqual(deploy.Spec, found.Spec) {
158160
found.Spec = deploy.Spec
159-
log.Printf("Updating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
161+
log.Info("Updating Deployment %s/%s\n", deploy.Namespace, deploy.Name)
160162
err = r.Update(context.TODO(), found)
161163
if err != nil {
162164
return reconcile.Result{}, err

test/project/pkg/controller/firstmate/firstmate_controller_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package firstmate
1818

1919
import (
20-
"log"
20+
stdlog "log"
2121
"os"
2222
"path/filepath"
2323
"sync"
@@ -42,7 +42,7 @@ func TestMain(m *testing.M) {
4242

4343
var err error
4444
if cfg, err = t.Start(); err != nil {
45-
log.Fatal(err)
45+
stdlog.Fatal(err)
4646
}
4747

4848
code := m.Run()

test/project/pkg/controller/frigate/frigate_controller_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package frigate
1818

1919
import (
20-
"log"
20+
stdlog "log"
2121
"os"
2222
"path/filepath"
2323
"sync"
@@ -42,7 +42,7 @@ func TestMain(m *testing.M) {
4242

4343
var err error
4444
if cfg, err = t.Start(); err != nil {
45-
log.Fatal(err)
45+
stdlog.Fatal(err)
4646
}
4747

4848
code := m.Run()

test/project/pkg/controller/healthcheckpolicy/healthcheckpolicy_controller_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package healthcheckpolicy
1818

1919
import (
20-
"log"
20+
stdlog "log"
2121
"os"
2222
"path/filepath"
2323
"sync"
@@ -42,7 +42,7 @@ func TestMain(m *testing.M) {
4242

4343
var err error
4444
if cfg, err = t.Start(); err != nil {
45-
log.Fatal(err)
45+
stdlog.Fatal(err)
4646
}
4747

4848
code := m.Run()

test/project/pkg/controller/kraken/kraken_controller_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package kraken
1818

1919
import (
20-
"log"
20+
stdlog "log"
2121
"os"
2222
"path/filepath"
2323
"sync"
@@ -42,7 +42,7 @@ func TestMain(m *testing.M) {
4242

4343
var err error
4444
if cfg, err = t.Start(); err != nil {
45-
log.Fatal(err)
45+
stdlog.Fatal(err)
4646
}
4747

4848
code := m.Run()

test/project/pkg/controller/namespace/namespace_controller_suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package namespace
1818

1919
import (
20-
"log"
20+
stdlog "log"
2121
"os"
2222
"path/filepath"
2323
"sync"
@@ -42,7 +42,7 @@ func TestMain(m *testing.M) {
4242

4343
var err error
4444
if cfg, err = t.Start(); err != nil {
45-
log.Fatal(err)
45+
stdlog.Fatal(err)
4646
}
4747

4848
code := m.Run()

0 commit comments

Comments
 (0)