Skip to content

Commit 3e4a6a2

Browse files
Remove builder requirements from generic wrapper methods
Signed-off-by: Danil Grigorev <[email protected]>
1 parent 4d77004 commit 3e4a6a2

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

example_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ func GenericExample() {
8787

8888
b := ctrl.NewControllerManagedBy(manager) // Create the Controller
8989
// ReplicaSet is the Application API
90-
b.Add(builder.For(b, &appsv1.ReplicaSet{})).
91-
Add(builder.Owns(b, &appsv1.ReplicaSet{}, &corev1.Pod{})). // ReplicaSet owns Pods created by it
90+
b.Add(builder.For(manager, &appsv1.ReplicaSet{})).
91+
Add(builder.Owns(manager, &appsv1.ReplicaSet{}, &corev1.Pod{})). // ReplicaSet owns Pods created by it
9292
Complete(&ReplicaSetReconciler{Client: manager.GetClient()})
9393
if err != nil {
9494
log.Error(err, "could not create controller")

pkg/builder/controller.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -187,25 +187,23 @@ func (blder *Builder) WatchesRawSource(src source.PrepareSyncing, eventHandler h
187187
return blder
188188
}
189189

190-
func For[T client.Object](blder *Builder, object T, prct ...predicate.ObjectPredicate[T]) source.Source {
191-
blder.forInput = ForInput{object: object}
192-
193-
return source.ObjectKind(blder.mgr.GetCache(), object).PrepareObject(&handler.EnqueueRequest[T]{}, prct...)
190+
func For[T client.Object](mgr manager.Manager, object T, prct ...predicate.ObjectPredicate[T]) source.Source {
191+
return source.ObjectKind(mgr.GetCache(), object).PrepareObject(&handler.EnqueueRequest[T]{}, prct...)
194192
}
195193

196-
func Owns[F, T client.Object](blder *Builder, owner F, owned T, prct ...predicate.ObjectPredicate[T]) source.Source {
197-
src := source.ObjectKind(blder.mgr.GetCache(), owned)
194+
func Owns[F, T client.Object](mgr manager.Manager, owner F, owned T, prct ...predicate.ObjectPredicate[T]) source.Source {
195+
src := source.ObjectKind(mgr.GetCache(), owned)
198196

199197
hdler := handler.EnqueueRequestForOwner(
200-
blder.mgr.GetScheme(), blder.mgr.GetRESTMapper(),
198+
mgr.GetScheme(), mgr.GetRESTMapper(),
201199
owner,
202200
)
203201

204202
return src.PrepareObject(handler.ObjectFuncAdapter[T](hdler), prct...)
205203
}
206204

207-
func Watches[T client.Object](blder *Builder, object T, eventHandler handler.ObjectHandler[T], prct ...predicate.ObjectPredicate[T]) source.Source {
208-
return source.ObjectKind(blder.mgr.GetCache(), object).PrepareObject(eventHandler, prct...)
205+
func Watches[T client.Object](mgr manager.Manager, object T, eventHandler handler.ObjectHandler[T], prct ...predicate.ObjectPredicate[T]) source.Source {
206+
return source.ObjectKind(mgr.GetCache(), object).PrepareObject(eventHandler, prct...)
209207
}
210208

211209
func (blder *Builder) Add(src source.Source) *Builder {

0 commit comments

Comments
 (0)