File tree Expand file tree Collapse file tree 1 file changed +7
-2
lines changed Expand file tree Collapse file tree 1 file changed +7
-2
lines changed Original file line number Diff line number Diff line change @@ -61,8 +61,8 @@ enable the restarting of controllers
61
61
62
62
The second goal of a solution for running controllers conditionally is addressed
63
63
by creating a wrapper around a controller called a ConditionalController that
64
- within its Start() function, it polls the discovery doc for the existence of the
65
- watched object and starts/stops/restarts the underlying controller as necessary
64
+ within its Start() function, polls the discovery doc for the existence of the
65
+ watched object and starts/stops/restarts the underlying controller as necessary.
66
66
67
67
The third goal of an ergonomic mechanism to use ConditionalControllers is a
68
68
small modification to the controller builder to enable running a controller as a
@@ -116,6 +116,11 @@ mitigation is to clear out the slices upon ConditionalController shutdown.
116
116
117
117
#### Alternatives
118
118
119
+ * A metacontroller or CRD controller could start and stop controllers based on
120
+ the existence of their corresponding CRDs. This requires no changes to made to
121
+ controller-runtime. It does put the complexity of designing such a controller
122
+ onto the end user, but there are potentially ways to provide end users with
123
+ default, pluggable CRD controllers.
119
124
* Instead of exposing ResetStart and SaveWatches on the internal controller struct
120
125
it might be better to expose it on the controller interface. This is more public
121
126
and creates more potential for abuse, but it prevents some hacky solutions
You can’t perform that action at this time.
0 commit comments