Skip to content

Commit 42eea42

Browse files
committed
Get manager coverage back up
1 parent 4358626 commit 42eea42

File tree

3 files changed

+10
-63
lines changed

3 files changed

+10
-63
lines changed

pkg/event/event_suite_test.go

Lines changed: 0 additions & 35 deletions
This file was deleted.

pkg/event/event_test.go

Lines changed: 0 additions & 25 deletions
This file was deleted.

pkg/manager/manager_test.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,6 @@ var _ = Describe("manger.Manager", func() {
172172
})
173173

174174
Describe("Add", func() {
175-
It("should fai if there is an erorr in SetFields", func() {
176-
})
177-
178175
It("should immediately start the Component if the Manager has already Started another Component",
179176
func(done Done) {
180177
m, err := New(cfg, Options{})
@@ -235,6 +232,12 @@ var _ = Describe("manger.Manager", func() {
235232

236233
close(done)
237234
})
235+
236+
It("should fail if SetFields fails", func() {
237+
m, err := New(cfg, Options{})
238+
Expect(err).NotTo(HaveOccurred())
239+
Expect(m.Add(&failRec{})).To(HaveOccurred())
240+
})
238241
})
239242
Describe("SetFields", func() {
240243
It("should inject field values", func(done Done) {
@@ -358,6 +361,10 @@ func (*failRec) Reconcile(reconcile.Request) (reconcile.Result, error) {
358361
return reconcile.Result{}, nil
359362
}
360363

364+
func (*failRec) Start(<-chan struct{}) error {
365+
return nil
366+
}
367+
361368
func (*failRec) InjectClient(client.Client) error {
362369
return fmt.Errorf("expected error")
363370
}

0 commit comments

Comments
 (0)