Merge pull request #193 from interma/fix-logr-usage

k8s-ci-robot · web-flow · commit 5675a5327544 · 2018-11-28T10:21:12.000-08:00
🐛 fix incorrect logr usage
diff --git a/pkg/source/source.go b/pkg/source/source.go
@@ -86,8 +86,8 @@ func (ks *Kind) Start(handler handler.EventHandler, queue workqueue.RateLimiting
 	i, err := ks.cache.GetInformer(ks.Type)
 	if err != nil {
 		if kindMatchErr, ok := err.(*meta.NoKindMatchError); ok {
-			log.Error(err, "if %s is a CRD, should install it before calling Start",
-				kindMatchErr.GroupKind)
+			log.Error(err, "if kind is a CRD, it should be installed before calling Start",
+				"kind", kindMatchErr.GroupKind)
 		}
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,8 @@ func (ks *Kind) Start(handler handler.EventHandler, queue workqueue.RateLimiting`
`86`	`86`	`i, err := ks.cache.GetInformer(ks.Type)`
`87`	`87`	`if err != nil {`
`88`	`88`	`if kindMatchErr, ok := err.(*meta.NoKindMatchError); ok {`
`89`		`- log.Error(err, "if %s is a CRD, should install it before calling Start",`
`90`		`- kindMatchErr.GroupKind)`
	`89`	`+ log.Error(err, "if kind is a CRD, it should be installed before calling Start",`
	`90`	`+ "kind", kindMatchErr.GroupKind)`
`91`	`91`	`}`
`92`	`92`	`return err`
`93`	`93`	`}`