🏃 Run tests with race detector enabled

Author: alvaroaleman

hack/test-all.sh

@@ -22,8 +22,7 @@ setup_envs
 
 header_text "running go test"
 
-# TODO(directxman12): enable the race detector once the LeaderElector race condition is resolved in client-go
-go test ${MOD_OPT} ./... -parallel 4
+go test -race ${MOD_OPT} ./... -parallel 4
 
 header_text "running coverage"
 

pkg/builder/controller_test.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"fmt"
 	"strings"
+	"sync/atomic"
 
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -214,7 +215,7 @@ var _ = Describe("application", func() {
 			var (
 				deployPrctExecuted     = false
 				replicaSetPrctExecuted = false
-				allPrctExecuted        = 0
+				allPrctExecuted        = int64(0)
 			)
 
 			deployPrct := predicate.Funcs{
@@ -246,7 +247,7 @@ var _ = Describe("application", func() {
 						BeAssignableToTypeOf(&appsv1.ReplicaSet{}),
 					))
 
-					allPrctExecuted++
+					atomic.AddInt64(&allPrctExecuted, 1)
 					return true
 				},
 			}

pkg/internal/testing/integration/internal/integration_tests/etcd_integration_test.go

@@ -39,9 +39,7 @@ var _ = Describe("Etcd", func() {
 		}
 
 		Expect(etcd.Start()).To(Succeed())
-		defer func() {
-			Expect(etcd.Stop()).To(Succeed())
-		}()
+		Expect(etcd.Stop()).To(Succeed())
 
 		Expect(stderr.String()).NotTo(BeEmpty())
 	})

pkg/internal/testing/integration/internal/process_test.go

@@ -216,6 +216,7 @@ var _ = Describe("Start method", func() {
 			processState.StartTimeout = 1 * time.Second
 
 			Expect(processState.Start(stdout, stderr)).To(Succeed())
+			Expect(processState.Session).Should(gexec.Exit())
 
 			Expect(stdout.String()).To(Equal("that is stdout\n"))
 			Expect(stderr.String()).To(Equal("this is stderr\ni started\n"))